Re: GDB ui word wrapping broken/interferes with 'set style' ?

[Philippe Waroquiers <philippe.waroquiers@skynet.be>]

On Mon, 2019-01-07 at 07:48 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
> 
> Philippe> Thanks for the investigations.  If you deem it useful, I can do
> Philippe> some manual validation of the patch, waiting for the test case and/or
> Philippe> unit test.
> 
> It's in crude form on my github, branch submit/fix-pager.
> 
> Tom
Seems to work much better, but I still found 2 strange things:

I debugged gdb with this gdb, did various commands, and then a bt full
which was ok:
(top-gdb) bt full
#0  0x00007f0b1ff97660 in __poll_nocancel () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x000055bd7edc2af1 in poll (__timeout=-1, __nfds=<optimized out>, __fds=<optimized out>)
    at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
No locals.
#2  gdb_wait_for_event (block=block@entry=1) at ../../binutils-gdb/gdb/event-loop.c:772
        timeout = -1
        file_ptr = <optimized out>
        num_found = 0
        __PRETTY_FUNCTION__ = "int gdb_wait_for_event(int)"


I changed the width to 40, and then there were a few lines and spaces before the  #0 
(I am not completely sure how to reproduce the below.  You might need to quit or C-c
a previous paged command.  So maybe this is the same problem as the next one
(maybe some data that stays in a buffer after a quit or C-c).

(top-gdb) set width 40
(top-gdb) bt full

          #0  0x00007f0b1ff97660 in __poll_nocancel ()
    at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x000055bd7edc2af1 in poll (
    __timeout=-1, 
    __nfds=<optimized out>, 
    __fds=<optimized out>)
    at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
No locals.
#2  gdb_wait_for_event (
    block=block@entry=1)
...


Also, when doing q (to stop paging):
...
#3  0x000055bd7edc2c54 in gdb_do_one_event ()
    at ../../binutils-gdb/gdb/event-loop.c:347
        number_of_sources = <optimized out>
        current = 3
        event_source_head = 2
        res = <optimized out>
#4  0x000055bd7edc2de5 in gdb_do_one_event ()
<continue without paging--q
 at ../../binutils-gdb/gdb/common/cQuit
(top-gdb) help
List of classes of commands:

aliases -- Aliases of other commands
breakpoints -- Making program stop at certain points
data -- Examining data
...

We still have the ' at ../../binutils-gdb/gdb/common/cQuit'
shown after the quit. It is shown in green, and then (top-gdb)
and all what follows (the help command, and its output) is in
green.
The color goes back to normal as soon as a command produces
some styled output (e.g.  p $sp).


Also, the msg at the end of each page also appears at different columns,
e.g.

...
#14 0x000055bd7edc37a9 in gdb_rl_callback_read_char_wrapper (
    client_data=<optimized out>)
    at ../../binutils-gdb/gdb/event-top.c:192
        gdb_expt = <optimized out>
<continue without paging--
#15 0x000055bd7edc3d50 in stdin_event_handler (error=<optimized out>, 
    client_data=0x55bd813aa840)
    at ../../binutils-gdb/gdb/event-top.c:511
        ui = 0x55bd813aa840
...
        exception_try_scope_instance = <optimized out>
        ex = <optimized out>
#22 gdb_main (args=<optimized out>)
    at ../../binutils-gdb/gdb/main.c:1193
        exception_try_scope_instance = {<continue without paging--
...


So, maybe something colored is still in a buffer, that is flushed
at various moments ?

Note that I also produced the above symptoms by playing
with set height 8, and quitting or C-c at various 'continue msg'.

Philippe