From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: GDB ui word wrapping broken/interferes with 'set style' ?
Date: Mon, 07 Jan 2019 13:46:00 -0000 [thread overview]
Message-ID: <1546868735.1926.19.camel@skynet.be> (raw)
In-Reply-To: <87d0p91hk3.fsf@tromey.com>
On Sun, 2019-01-06 at 16:40 -0700, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
>
> Philippe> For word wrapping, I could not make it split addresses anymore,
> Philippe> but I still see differences with the 8.2 behaviour,
> Philippe> where the new gdb git+patch still splits filenames or some values.
> [...]
>
> Ok, I think I finally found this. I have a patch that works for me.
> I still have to write a test case.
>
> I looked into writing a unit test, but that is pretty complicated given
> the many conditions at the top of fputs_maybe_filtered. I suppose I'd
> have to install a new top level interpreter to make it possible, among
> other things. (It seems to me that maybe this should check some
> property of the ui_file and not the interpreter, but that's a much
> larger patch...)
>
> Tom
Thanks for the investigations. If you deem it useful, I can do
some manual validation of the patch, waiting for the test case and/or
unit test.
Philippe
next prev parent reply other threads:[~2019-01-07 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 14:51 Philippe Waroquiers
2018-12-30 20:26 ` Tom Tromey
2018-12-30 23:45 ` Tom Tromey
2018-12-31 8:13 ` Philippe Waroquiers
2019-01-06 23:40 ` Tom Tromey
2019-01-07 13:46 ` Philippe Waroquiers [this message]
2019-01-07 14:49 ` Tom Tromey
2019-01-07 16:56 ` Philippe Waroquiers
2019-01-12 17:03 ` Tom Tromey
2019-01-12 17:55 ` Philippe Waroquiers
2019-01-12 21:08 ` Philippe Waroquiers
2019-01-14 3:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546868735.1926.19.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox