From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18079 invoked by alias); 7 Jan 2019 13:46:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17859 invoked by uid 89); 7 Jan 2019 13:45:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=investigations X-HELO: mailsec118.isp.belgacom.be Received: from mailsec118.isp.belgacom.be (HELO mailsec118.isp.belgacom.be) (195.238.20.114) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jan 2019 13:45:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1546868737; x=1578404737; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=bB/QFsWe0+PNPdRJm6m7Y9Yi51HHIuOxUnOjllvyZdA=; b=jdZI3b+jzAvhpCsSHLsAEN9A6i0g6Iw6ejn0ghMamWS2GdfmL1Z9bp9I aSytABgi9lk2YpYUXxknGlSBwwY4Aw==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 07 Jan 2019 14:45:35 +0100 Message-ID: <1546868735.1926.19.camel@skynet.be> Subject: Re: GDB ui word wrapping broken/interferes with 'set style' ? From: Philippe Waroquiers To: Tom Tromey Cc: gdb-patches@sourceware.org Date: Mon, 07 Jan 2019 13:46:00 -0000 In-Reply-To: <87d0p91hk3.fsf@tromey.com> References: <1546181481.12900.10.camel@skynet.be> <87ftuelq21.fsf@tromey.com> <877efqlgu6.fsf@tromey.com> <1546244005.12900.20.camel@skynet.be> <87d0p91hk3.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00125.txt.bz2 On Sun, 2019-01-06 at 16:40 -0700, Tom Tromey wrote: > > > > > > "Philippe" == Philippe Waroquiers writes: > > Philippe> For word wrapping, I could not make it split addresses anymore, > Philippe> but I still see differences with the 8.2 behaviour, > Philippe> where the new gdb git+patch still splits filenames or some values. > [...] > > Ok, I think I finally found this. I have a patch that works for me. > I still have to write a test case. > > I looked into writing a unit test, but that is pretty complicated given > the many conditions at the top of fputs_maybe_filtered. I suppose I'd > have to install a new top level interpreter to make it possible, among > other things. (It seems to me that maybe this should check some > property of the ui_file and not the interpreter, but that's a much > larger patch...) > > Tom Thanks for the investigations. If you deem it useful, I can do some manual validation of the patch, waiting for the test case and/or unit test. Philippe