From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24400 invoked by alias); 30 Dec 2018 23:45:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24292 invoked by uid 89); 30 Dec 2018 23:45:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.133) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Dec 2018 23:45:15 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 3BF4A400D4D27 for ; Sun, 30 Dec 2018 17:45:06 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dklWg7lsd4FKpdklWgazj1; Sun, 30 Dec 2018 17:45:06 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fKf14Uj126gKkUYBK4FiHjZm26hWMkBtqvJdziCAfp4=; b=njAAVkq/SnKhLsd0nx6rGzt/WP HnIbIBnO60kHiD/w9gz+dlJ0EDO4nhugRjbW3yVQcyyTr7T/pttpP2sFzNJxVtwTe9k6X9Ty/LoSy nI51TdgMjeChn3b7sQBcV4vML; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:42186 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gdklW-003HNP-AR; Sun, 30 Dec 2018 17:45:06 -0600 From: Tom Tromey To: Tom Tromey Cc: Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: GDB ui word wrapping broken/interferes with 'set style' ? References: <1546181481.12900.10.camel@skynet.be> <87ftuelq21.fsf@tromey.com> Date: Sun, 30 Dec 2018 23:45:00 -0000 In-Reply-To: <87ftuelq21.fsf@tromey.com> (Tom Tromey's message of "Sun, 30 Dec 2018 13:25:58 -0700") Message-ID: <877efqlgu6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00442.txt.bz2 Tom> Seems very likely. Thanks for the report, I will look into it. Please try this. I think it fixes both of the styling problems you reported, but it's better if you check it too. If it works for you I will write a test case. thanks, Tom diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 7be4360e62..0d1fcb79f1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-12-30 Tom Tromey + + * utils.c (flush_wrap_buffer): Only flush gdb_stdout. + 2018-12-30 Tom Tromey * event-top.h (command_line_handler): Update. diff --git a/gdb/utils.c b/gdb/utils.c index 3a6f796f2b..753eb14280 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -1589,7 +1589,7 @@ reinitialize_more_filter (void) static void flush_wrap_buffer (struct ui_file *stream) { - if (!wrap_buffer.empty ()) + if (stream == gdb_stdout && !wrap_buffer.empty ()) { fputs_unfiltered (wrap_buffer.c_str (), stream); wrap_buffer.clear ();