Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Remove redundant typedefs
Date: Fri, 04 Dec 2020 13:09:08 -0700	[thread overview]
Message-ID: <877dpx5o63.fsf@tromey.com> (raw)
In-Reply-To: <7de06bf6-c76c-cb57-5219-d5b6637f639d@palves.net> (Pedro Alves's message of "Fri, 4 Dec 2020 00:18:41 +0000")

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> This comment becomes stale, as you've removed the typedef
Pedro> in guile-internal.h.

Pedro> These probably also need tweaking:

Pedro>  $ grep "typedef for" -rn | grep internal
Pedro>  guile/scm-iterator.c:59:   The typedef for this struct is in guile-internal.h.  */
Pedro>  guile/scm-objfile.c:29:   The typedef for this struct is in guile-internal.h.  */
Pedro>  guile/scm-progspace.c:32:   The typedef for this struct is in guile-internal.h.  */
Pedro>  guile/scm-frame.c:36:   The typedef for this struct is in guile-internal.h.  */
Pedro>  guile/scm-type.c:38:   The typedef for this struct is in guile-internal.h.  */
Pedro>  guile/scm-arch.c:30:   The typedef for this struct is in guile-internal.h.  */

Thanks, I fixed this up.

Tom

      reply	other threads:[~2020-12-04 20:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 19:24 Tom Tromey
2020-12-03 19:33 ` Simon Marchi
2020-12-04 20:08   ` Tom Tromey
2020-12-04  0:18 ` Pedro Alves
2020-12-04 20:09   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dpx5o63.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox