From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id II+qD2mXyl+hPwAAWB0awg (envelope-from ) for ; Fri, 04 Dec 2020 15:09:13 -0500 Received: by simark.ca (Postfix, from userid 112) id 3783D1F0AB; Fri, 4 Dec 2020 15:09:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A20271E552 for ; Fri, 4 Dec 2020 15:09:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69C063860C39; Fri, 4 Dec 2020 20:09:12 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 17D8D385EC55 for ; Fri, 4 Dec 2020 20:09:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 17D8D385EC55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D7DD75632E; Fri, 4 Dec 2020 15:09:09 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AVnxjlXfK7MO; Fri, 4 Dec 2020 15:09:09 -0500 (EST) Received: from murgatroyd (97-122-89-243.hlrn.qwest.net [97.122.89.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 7A470117427; Fri, 4 Dec 2020 15:09:09 -0500 (EST) From: Tom Tromey To: Pedro Alves Subject: Re: [PATCH] Remove redundant typedefs References: <20201203192419.2861728-1-tromey@adacore.com> <7de06bf6-c76c-cb57-5219-d5b6637f639d@palves.net> X-Attribution: Tom Date: Fri, 04 Dec 2020 13:09:08 -0700 In-Reply-To: <7de06bf6-c76c-cb57-5219-d5b6637f639d@palves.net> (Pedro Alves's message of "Fri, 4 Dec 2020 00:18:41 +0000") Message-ID: <877dpx5o63.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org, Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Pedro" == Pedro Alves writes: Pedro> This comment becomes stale, as you've removed the typedef Pedro> in guile-internal.h. Pedro> These probably also need tweaking: Pedro> $ grep "typedef for" -rn | grep internal Pedro> guile/scm-iterator.c:59: The typedef for this struct is in guile-internal.h. */ Pedro> guile/scm-objfile.c:29: The typedef for this struct is in guile-internal.h. */ Pedro> guile/scm-progspace.c:32: The typedef for this struct is in guile-internal.h. */ Pedro> guile/scm-frame.c:36: The typedef for this struct is in guile-internal.h. */ Pedro> guile/scm-type.c:38: The typedef for this struct is in guile-internal.h. */ Pedro> guile/scm-arch.c:30: The typedef for this struct is in guile-internal.h. */ Thanks, I fixed this up. Tom