From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove redundant typedefs
Date: Thu, 3 Dec 2020 14:33:28 -0500 [thread overview]
Message-ID: <056c4f42-4e85-dcaf-59e1-8483e9b6f876@simark.ca> (raw)
In-Reply-To: <20201203192419.2861728-1-tromey@adacore.com>
On 2020-12-03 2:24 p.m., Tom Tromey wrote:
> @@ -794,7 +794,7 @@ struct breakpoint
> gdbpy_breakpoint_object *py_bp_object = NULL;
>
> /* Same as py_bp_object, but for Scheme. */
> - gdbscm_breakpoint_object *scm_bp_object = NULL;
> + breakpoint_smob *scm_bp_object = NULL;
In this case, I think it would make sense to keep the
"gdbscm_breakpoint_object" name, first for symmetry with Python, but
also because it's more descriptive than "breakpoint_smob", when you are
not in the guile code.
Since the code in scm-breakpoint.c uses breakpoint_smob everywhere (and
in the context of guile, it's clear what a _smob is), you could just add
a
using breakpoint_smob = gdbscm_breakpoint_object;
in that file.
But other than that, this LGTM, thanks!
Simon
next prev parent reply other threads:[~2020-12-03 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 19:24 Tom Tromey
2020-12-03 19:33 ` Simon Marchi [this message]
2020-12-04 20:08 ` Tom Tromey
2020-12-04 0:18 ` Pedro Alves
2020-12-04 20:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=056c4f42-4e85-dcaf-59e1-8483e9b6f876@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox