From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove redundant typedefs
Date: Fri, 4 Dec 2020 00:18:41 +0000 [thread overview]
Message-ID: <7de06bf6-c76c-cb57-5219-d5b6637f639d@palves.net> (raw)
In-Reply-To: <20201203192419.2861728-1-tromey@adacore.com>
On 12/3/20 7:24 PM, Tom Tromey wrote:
> diff --git a/gdb/guile/scm-arch.c b/gdb/guile/scm-arch.c
> index 953cb226d98..7ff821ed4e2 100644
> --- a/gdb/guile/scm-arch.c
> +++ b/gdb/guile/scm-arch.c
> @@ -29,7 +29,7 @@
> /* The <gdb:arch> smob.
> The typedef for this struct is in guile-internal.h. */
This comment becomes stale, as you've removed the typedef
in guile-internal.h.
These probably also need tweaking:
$ grep "typedef for" -rn | grep internal
guile/scm-iterator.c:59: The typedef for this struct is in guile-internal.h. */
guile/scm-objfile.c:29: The typedef for this struct is in guile-internal.h. */
guile/scm-progspace.c:32: The typedef for this struct is in guile-internal.h. */
guile/scm-frame.c:36: The typedef for this struct is in guile-internal.h. */
guile/scm-type.c:38: The typedef for this struct is in guile-internal.h. */
guile/scm-arch.c:30: The typedef for this struct is in guile-internal.h. */
>
> -struct _arch_smob
> +struct arch_smob
> {
> /* This always appears first. */
> gdb_smob base;
next prev parent reply other threads:[~2020-12-04 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 19:24 Tom Tromey
2020-12-03 19:33 ` Simon Marchi
2020-12-04 20:08 ` Tom Tromey
2020-12-04 0:18 ` Pedro Alves [this message]
2020-12-04 20:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de06bf6-c76c-cb57-5219-d5b6637f639d@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox