From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gs5LOWmAyV/eIAAAWB0awg (envelope-from ) for ; Thu, 03 Dec 2020 19:18:49 -0500 Received: by simark.ca (Postfix, from userid 112) id E3C2A1F0AB; Thu, 3 Dec 2020 19:18:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 707AD1E58E for ; Thu, 3 Dec 2020 19:18:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6B68396EC72; Fri, 4 Dec 2020 00:18:48 +0000 (GMT) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by sourceware.org (Postfix) with ESMTPS id E76D2395C00F for ; Fri, 4 Dec 2020 00:18:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E76D2395C00F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f65.google.com with SMTP id l1so3643752wrb.9 for ; Thu, 03 Dec 2020 16:18:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5OiO6pZUoZA7c+Bqaco0xlfl4HDkQO7rXxLW37ZwrY4=; b=WerhyrBOx5jumrA3On8FyTwnBrdbtsGjaEzaj5zHE4SM5Y1m0OAoPi5cSpwR4GGC5t k+pHukKH8pda6YkDeNItv+HOt459JJxygEjdy2+C7b8KFtlJdNWSRGfx8mAZhCPnFLyo L7FgTp1v8/N8OzqMx1vmcKXM6ptLDYQGz+w2qUuJ9fZqmqQK/iRrwVy+dn3slnT0gYEs 35np05ijND3myOPs04NFyQ4GpRxZp8IvuaPe6yIvBPy9pUBrLquj/bh9QA1lvKeCVRJU 9o8oOb9zb1Eb+rMs0wxaUzuligNitgypbgkBHVEo+aOI1iB+vq8O5dWujdymEG8mOAKo iSOA== X-Gm-Message-State: AOAM532BS8t3ZIKLtgUNK/wZnJK2NAe9bho4kLW0R9jz5+RSeM97AtvA pI7MrvMcXwCefL0kGJxH2R4z5pnkEFIpMQ== X-Google-Smtp-Source: ABdhPJyW/tBNhNpe/ygqp5KsGQS+a9yQDF7Q/k0oSnrat4zmW2FnFwwxoANFI5FgI6hV8Fgew+KnTQ== X-Received: by 2002:a5d:4746:: with SMTP id o6mr1786751wrs.324.1607041124092; Thu, 03 Dec 2020 16:18:44 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id o21sm1384560wra.40.2020.12.03.16.18.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 16:18:43 -0800 (PST) Subject: Re: [PATCH] Remove redundant typedefs To: Tom Tromey , gdb-patches@sourceware.org References: <20201203192419.2861728-1-tromey@adacore.com> From: Pedro Alves Message-ID: <7de06bf6-c76c-cb57-5219-d5b6637f639d@palves.net> Date: Fri, 4 Dec 2020 00:18:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20201203192419.2861728-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 12/3/20 7:24 PM, Tom Tromey wrote: > diff --git a/gdb/guile/scm-arch.c b/gdb/guile/scm-arch.c > index 953cb226d98..7ff821ed4e2 100644 > --- a/gdb/guile/scm-arch.c > +++ b/gdb/guile/scm-arch.c > @@ -29,7 +29,7 @@ > /* The smob. > The typedef for this struct is in guile-internal.h. */ This comment becomes stale, as you've removed the typedef in guile-internal.h. These probably also need tweaking: $ grep "typedef for" -rn | grep internal guile/scm-iterator.c:59: The typedef for this struct is in guile-internal.h. */ guile/scm-objfile.c:29: The typedef for this struct is in guile-internal.h. */ guile/scm-progspace.c:32: The typedef for this struct is in guile-internal.h. */ guile/scm-frame.c:36: The typedef for this struct is in guile-internal.h. */ guile/scm-type.c:38: The typedef for this struct is in guile-internal.h. */ guile/scm-arch.c:30: The typedef for this struct is in guile-internal.h. */ > > -struct _arch_smob > +struct arch_smob > { > /* This always appears first. */ > gdb_smob base;