Re: [PATCH v2 2/2] [gdb/symtab] Fix data race in try_open_dwop_file

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> The call to bfd_check_format in try_open_dwop_file:
Tom> ...
Tom>     /* The operations below are not thread-safe, use a lock to synchronize
Tom>        concurrent accesses.  */
Tom>     static gdb::mutex mutex;
Tom>     gdb::lock_guard<gdb::mutex> lock (mutex);

Tom>     if (!bfd_check_format (sym_bfd.get (), bfd_object))
Tom>       return NULL;
Tom> ...
Tom> accesses the sym_bfd.get () BFD, so it should be guarded by the global BFD
Tom> lock.

Doesn't bfd_check_format do this itself?
Otherwise, don't we need to wrap all calls to bfd_check_format?

Tom> The local lock also guarded a call to gdb_bfd_record_inclusion, which doesn't
Tom> do any locking, so likewise use the global BFD lock in
Tom> gdb_bfd_record_inclusion.

This part seems unobjectionable to me.

Tom