From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qc7RKoeWqGlYfxQAWB0awg (envelope-from ) for ; Wed, 04 Mar 2026 15:31:03 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=MRewZ2hQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A91341E0DD; Wed, 04 Mar 2026 15:31:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E42FC1E089 for ; Wed, 04 Mar 2026 15:31:02 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6D6154BA23E8 for ; Wed, 4 Mar 2026 20:31:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D6154BA23E8 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=MRewZ2hQ Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 6827D4BA23C5 for ; Wed, 4 Mar 2026 20:30:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6827D4BA23C5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6827D4BA23C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772656208; cv=none; b=lFJeVoutqCgCPIyQrAKPeGH4Cm3vcD7PbGKhMzVVWjocreSo2YFiHqaUoEwVUoimpM6J5reMWG78AdudHGj4JRfZn+F8mwwjcEmKOix3734wUmmq9H4P2dApTIs4xncOzcM5PZBLZl97q3/Y0UXk240s8GjHZJWIkmOu/c3g/3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772656208; c=relaxed/simple; bh=Jcsqbo9P6pHMuclxLrRoDzUWN+TWPCeQugzTpaieAC4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nMCKpjAGTUzQag5Gf82Ub8GDB5bLFIkZznIJFBjgw28QEgy3EqW+arHwTGvsRWCjRaxw+jEcwYkwWzZF3sicOx0N/rmpiU6UgAMOkArSwKdnaji5A2Vow7PSdjH/jULOsDtLjwrgpfZe9A5KusBgW6LdlXeSQvpYww3rYnR2J28= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6827D4BA23C5 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id xsKKvKr0KKjfoxsr9vfqDG; Wed, 04 Mar 2026 20:30:07 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xsqyvyhrSvXvHxsqzvhUaz; Wed, 04 Mar 2026 20:29:57 +0000 X-Authority-Analysis: v=2.4 cv=e4IGSbp/ c=1 sm=1 tr=0 ts=69a8964f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=oSGAYMYfc8gJGCuhy-UA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2RRO7hI0An5Mu9winafyBsy0GvjWKR//3wtSpYjKLDw=; b=MRewZ2hQb35v4Ul9Eb93yVUfF6 nCHu4LjcktejVfsBJofK+TE2jKxfeePkD83b16IJtzKwD0xRRFcyZ60P6sz2fKG5x3IrH/duZv3mI q5KDz5ua1qext427amcgs2yTS; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:51850 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vxsqy-00000002zOd-2h47; Wed, 04 Mar 2026 13:29:56 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] [gdb/symtab] Fix data race in try_open_dwop_file In-Reply-To: <20260216180925.3174052-3-tdevries@suse.de> (Tom de Vries's message of "Mon, 16 Feb 2026 19:09:25 +0100") References: <20260216180925.3174052-1-tdevries@suse.de> <20260216180925.3174052-3-tdevries@suse.de> X-Attribution: Tom Date: Wed, 04 Mar 2026 13:29:55 -0700 Message-ID: <877brrnxrw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vxsqy-00000002zOd-2h47 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:51850 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPQTiquyWhHcUySN1rwDTUyO42d9ncympki6PvyoLt/95dxf9KLDNPjdwreQw516YCmmAKPDfEQssTrG1kDZImlZSxTDtCzMzSjFcFJ77+xoW+V2a0Ff 14ZMkglTFOBSISah8lcWz15ORxfjXh6RKTPbaceFMBtJf7quVvie8o5FAo/GLHKlZr5Aayj7ClIleznz5HRBTyGTAn3NUf8Il0w= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> The call to bfd_check_format in try_open_dwop_file: Tom> ... Tom> /* The operations below are not thread-safe, use a lock to synchronize Tom> concurrent accesses. */ Tom> static gdb::mutex mutex; Tom> gdb::lock_guard lock (mutex); Tom> if (!bfd_check_format (sym_bfd.get (), bfd_object)) Tom> return NULL; Tom> ... Tom> accesses the sym_bfd.get () BFD, so it should be guarded by the global BFD Tom> lock. Doesn't bfd_check_format do this itself? Otherwise, don't we need to wrap all calls to bfd_check_format? Tom> The local lock also guarded a call to gdb_bfd_record_inclusion, which doesn't Tom> do any locking, so likewise use the global BFD lock in Tom> gdb_bfd_record_inclusion. This part seems unobjectionable to me. Tom