Re: [PATCH v2 1/2] [gdb/symtab] Replace per-BFD lock with global BFD lock

[Tom de Vries <tdevries@suse.de>]

On 3/4/26 9:20 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> A naive way to implement this using the existing scheme of wrappers, would be to
> Tom> add a gdb_bfd_cache_close_all that locks all per-BFD locks, calls
> Tom> bfd_cache_close_all, and unlocks all per-BFD locks, like this:
> 
> I've long considered the BFD cache to be pretty bad.  I am not sure what
> would be better but it really doesn't work all that nicely for gdb,
> particularly with threads.
> 
> Anyway I think this patch is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
> 

Thanks for the review, I've pushed this.

BTW, I shortened the commit log a bit, I realized it didn't really need 
the lengthy "complicated scheme" implementation pasted in there, given 
that there's a reference to the corresponding patch.

> I do wonder whether this causes any more lock contention.

Yeah, that seems likely.

Thanks,
- Tom