From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QyZpFATyqWkPpBcAWB0awg (envelope-from ) for ; Thu, 05 Mar 2026 16:13:40 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NKCm+lVa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KoI6NCew; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=j3ypo8KL; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=u+HHDmSV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 27E5E1E0DD; Thu, 05 Mar 2026 16:13:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 679991E089 for ; Thu, 05 Mar 2026 16:13:39 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0CDCE4BA23CF for ; Thu, 5 Mar 2026 21:13:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CDCE4BA23CF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NKCm+lVa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=KoI6NCew; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=j3ypo8KL; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=u+HHDmSV Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id E9AA04BA2E0D for ; Thu, 5 Mar 2026 21:13:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9AA04BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9AA04BA2E0D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772745191; cv=none; b=CZLJ3+pNWtp1kQbzjuKrinTd+NwczdZ0nbC5RwrsYW8RNc6395WlIwxkWRPJXdERVhCj2S2rrR9P4dbTMQiKWQXspAm/G7ovqyY79lRFK8/jYgNJsWqb7NIErL22i/yiWi7U/6hAZHshqbSfpKnW2CXWgzk0gV8r9uUNNvgUbQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772745191; c=relaxed/simple; bh=gj5O/V8OV+7I9m+kqLOyw8+F5TRYuZiH2LV0ClS5N+Q=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=IOgAaNPXPy7Pc77BFrbFh9Nq3p/JQh3QHHPtG40np5IqEuD6ZMNyggwZH1STcu4w5XfNV5rhJS8t2sniKJnaWZzC+yAZegU+3Iaty7+KO8EnhGByT8vYlQE2x6XrM7719bGId4Rt31WBjtierDyJJuLU9VBniGdMkrg80DSGuIw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9AA04BA2E0D Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D69723F834; Thu, 5 Mar 2026 21:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772745190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2l6JCJaqDcy5MTIZAUZghx3yCi+qr1xNH3JSiVtOTCU=; b=NKCm+lVaKUrPBwn0ceObWRFfe3/Fo1UvpQ1uyQ/erxlex0Is5fKLtsnTpHdiWx/5N3Voyn jDhx6kJHnaHL4UDPXdBDoZyHz21qobQsuzdTC3sRv4IDtohPsKjov+FKL18ayVb6OiwGWI fcIjevmzaLr376YHZk8wiktDjUViG44= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772745190; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2l6JCJaqDcy5MTIZAUZghx3yCi+qr1xNH3JSiVtOTCU=; b=KoI6NCewBzhfpnqd55qnHJ5ZoopNwq1b/jfk7hCGylkqa1fPQKuEV+6Ve/q4bwPdbBNnKD pqukYTPTNNv21nCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772745189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2l6JCJaqDcy5MTIZAUZghx3yCi+qr1xNH3JSiVtOTCU=; b=j3ypo8KLBKG/zENUrcYvQ2Wq1AFgwI1W+oAs8kITmSyAUkBibmwrnWG/oIRsP5bFLQGfOw cELMfmBYSnx1cndEpbf8x3CWVepxus7J2kWggwbr4/2sbWr7OtE/4Xwn7E6ASMxchVAl3m g0ijr7bE0d/of3lQPpT6fhQRBfVstyI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772745189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2l6JCJaqDcy5MTIZAUZghx3yCi+qr1xNH3JSiVtOTCU=; b=u+HHDmSVjPozidpfovLj6D1OJx8L1v2ltEgTx+PosvzP9lTWVnDipRHE6/TRMxEzS5EBH5 nvDhmBQpHVahrnDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BF6133EA68; Thu, 5 Mar 2026 21:13:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8/1iLeXxqWn4FQAAD6G6ig (envelope-from ); Thu, 05 Mar 2026 21:13:09 +0000 Message-ID: <1f50b9b7-fd3a-4df4-896c-87d721ba23dc@suse.de> Date: Thu, 5 Mar 2026 22:13:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] [gdb/symtab] Replace per-BFD lock with global BFD lock To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260216180925.3174052-1-tdevries@suse.de> <20260216180925.3174052-2-tdevries@suse.de> <87bjh3ny76.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87bjh3ny76.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.19)[-0.949]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/4/26 9:20 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> A naive way to implement this using the existing scheme of wrappers, would be to > Tom> add a gdb_bfd_cache_close_all that locks all per-BFD locks, calls > Tom> bfd_cache_close_all, and unlocks all per-BFD locks, like this: > > I've long considered the BFD cache to be pretty bad. I am not sure what > would be better but it really doesn't work all that nicely for gdb, > particularly with threads. > > Anyway I think this patch is ok. > Approved-By: Tom Tromey > Thanks for the review, I've pushed this. BTW, I shortened the commit log a bit, I realized it didn't really need the lengthy "complicated scheme" implementation pasted in there, given that there's a reference to the corresponding patch. > I do wonder whether this causes any more lock contention. Yeah, that seems likely. Thanks, - Tom