From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] [gdb/symtab] Replace per-BFD lock with global BFD lock
Date: Wed, 04 Mar 2026 13:20:45 -0700 [thread overview]
Message-ID: <87bjh3ny76.fsf@tromey.com> (raw)
In-Reply-To: <20260216180925.3174052-2-tdevries@suse.de> (Tom de Vries's message of "Mon, 16 Feb 2026 19:09:24 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> A naive way to implement this using the existing scheme of wrappers, would be to
Tom> add a gdb_bfd_cache_close_all that locks all per-BFD locks, calls
Tom> bfd_cache_close_all, and unlocks all per-BFD locks, like this:
I've long considered the BFD cache to be pretty bad. I am not sure what
would be better but it really doesn't work all that nicely for gdb,
particularly with threads.
Anyway I think this patch is ok.
Approved-By: Tom Tromey <tom@tromey.com>
I do wonder whether this causes any more lock contention.
Tom
next prev parent reply other threads:[~2026-03-04 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 18:09 [PATCH v2 0/2] [gdb] TSAN fixes Tom de Vries
2026-02-16 18:09 ` [PATCH v2 1/2] [gdb/symtab] Replace per-BFD lock with global BFD lock Tom de Vries
2026-03-04 20:20 ` Tom Tromey [this message]
2026-03-05 21:13 ` Tom de Vries
2026-02-16 18:09 ` [PATCH v2 2/2] [gdb/symtab] Fix data race in try_open_dwop_file Tom de Vries
2026-03-04 20:29 ` Tom Tromey
2026-05-27 19:16 ` Tom de Vries
2026-05-27 20:48 ` Tom Tromey
2026-05-27 21:55 ` Tom de Vries
2026-03-03 15:34 ` [PING][PATCH v2 0/2] [gdb] TSAN fixes Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjh3ny76.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox