Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Check code stype in Emacs: gdb-code-style.el
Date: Mon, 16 Apr 2012 20:01:00 -0000	[thread overview]
Message-ID: <8762cz1qyn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1334378614-13787-1-git-send-email-yao@codesourcery.com> (Yao	Qi's message of "Sat, 14 Apr 2012 12:43:34 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> gdb-code-style.el gives some checks, and highlight corresponding parts
Yao> if they are violations on a certain rule or convention in gdb development.
Yao> So far, it only has two, and I'd like to push more, if it is the right
Yao> way to go.

Super, let's do it.

Yao> diff --git a/gdb/gdb-code-style.el b/gdb/gdb-code-style.el
Yao> new file mode 100644
Yao> index 0000000..5919e3d
Yao> --- /dev/null
Yao> +++ b/gdb/gdb-code-style.el
Yao> @@ -0,0 +1,35 @@
Yao> +;; Emacs settings to check various code styles.
Yao> +;; Copyright (C) 2012 Free Software Foundation, Inc.

Could you make this conform to the elisp comment-header guidelines?
See (info "(elisp) Library Headers").

With this change people can M-x package-install-file the .el if they
want.  (In fact that is a decent way to test the headers; package.el is
kind of picky about the formatting.)

Ok with that change.

Tom


  parent reply	other threads:[~2012-04-16 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-14  7:46 Yao Qi
2012-04-14 12:24 ` Eli Zaretskii
2012-04-16 20:01 ` Tom Tromey [this message]
2012-04-19  4:14   ` [committed] : " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762cz1qyn.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox