From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Check code stype in Emacs: gdb-code-style.el
Date: Sat, 14 Apr 2012 12:24:00 -0000 [thread overview]
Message-ID: <83wr5i21wc.fsf@gnu.org> (raw)
In-Reply-To: <1334378614-13787-1-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Sat, 14 Apr 2012 12:43:34 +0800
>
> gdb-code-style.el gives some checks, and highlight corresponding parts
> if they are violations on a certain rule or convention in gdb development.
> So far, it only has two, and I'd like to push more, if it is the right
> way to go.
Thanks.
> +;; Don't include these files directly.
> +(defun gdb-include-hook ()
> + (font-lock-add-keywords
> + nil
> + '(("\\<include[ ]*\\(<\\(stat\\|dirent\\|wait\\|sys/wait\\|assert\\)\\.h>\\)" 1 font-lock-warning-face t))))
This catches '#include <stat.h>', but doesn't catch '#include "sys/stat.h"'.
next prev parent reply other threads:[~2012-04-14 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 7:46 Yao Qi
2012-04-14 12:24 ` Eli Zaretskii [this message]
2012-04-16 20:01 ` Tom Tromey
2012-04-19 4:14 ` [committed] : " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wr5i21wc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox