From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89857-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3659 invoked by alias); 14 Apr 2012 07:46:59 -0000
Received: (qmail 3641 invoked by uid 22791); 14 Apr 2012 07:46:58 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 Apr 2012 07:46:43 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M2G00900KM48L00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 14 Apr 2012 10:46:32 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.57.204]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M2G009D4LLJ6H50@a-mtaout22.012.net.il>; Sat, 14 Apr 2012 10:46:32 +0300 (IDT)
Date: Sat, 14 Apr 2012 12:24:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Check code stype in Emacs: gdb-code-style.el
In-reply-to: <1334378614-13787-1-git-send-email-yao@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83wr5i21wc.fsf@gnu.org>
References: <1334378614-13787-1-git-send-email-yao@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00392.txt.bz2

> From: Yao Qi <yao@codesourcery.com>
> Date: Sat, 14 Apr 2012 12:43:34 +0800
> 
> gdb-code-style.el gives some checks, and highlight corresponding parts
> if they are violations on a certain rule or convention in gdb development.
> So far, it only has two, and I'd like to push more, if it is the right
> way to go.

Thanks.

> +;; Don't include these files directly.
> +(defun gdb-include-hook ()
> +  (font-lock-add-keywords
> +   nil
> +   '(("\\<include[ ]*\\(<\\(stat\\|dirent\\|wait\\|sys/wait\\|assert\\)\\.h>\\)" 1 font-lock-warning-face t))))

This catches '#include <stat.h>', but doesn't catch '#include "sys/stat.h"'.