Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [committed] : [PATCH] Check code stype in Emacs: gdb-code-style.el
Date: Thu, 19 Apr 2012 04:14:00 -0000	[thread overview]
Message-ID: <4F8F722D.40603@codesourcery.com> (raw)
In-Reply-To: <8762cz1qyn.fsf@fleche.redhat.com>

On 04/17/2012 02:17 AM, Tom Tromey wrote:
> Could you make this conform to the elisp comment-header guidelines?
> See (info "(elisp) Library Headers").
> 
> With this change people can M-x package-install-file the .el if they
> want.  (In fact that is a decent way to test the headers; package.el is
> kind of picky about the formatting.)
> 
> Ok with that change.

This is what I committed with some minor changes to comply to comment
header guidelines.
http://sourceware.org/ml/gdb-cvs/2012-04/msg00139.html

-- 
Yao (齐尧) 

gdb:

	* gdb-code-style.el: New.
---
 gdb/gdb-code-style.el |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 48 insertions(+), 0 deletions(-)
 create mode 100644 gdb/gdb-code-style.el

diff --git a/gdb/gdb-code-style.el b/gdb/gdb-code-style.el
new file mode 100644
index 0000000..5897831
--- /dev/null
+++ b/gdb/gdb-code-style.el
@@ -0,0 +1,48 @@
+;;; gdb-code-style.el --- code style checker for GDB contributors
+
+;; Copyright (C) 2012 Free Software Foundation, Inc.
+
+;; Author: Yao Qi <yao@codesourcery.com>
+;; Created: 17 April 2012
+;; Version: 1.0
+;; Keywords: GDB
+
+;; This program is free software; you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation; either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; These hooks defined in this file provide some code style checks in
+;; Emacs.  You can load it in your ~/.emacs,
+;; (load-file "~/$(GDB_SOURCE)/gdb/gdb-code-style.el")
+
+
+;;; Code:
+
+;; Don't use these functions.  Their alternatives are better.  This list
+;; of functions is from ARI rules.
+(defun gdb-fun-name-hook ()
+  (font-lock-add-keywords
+   nil
+   '(("\\<\\(\\(xasprintf\\|abort\\|vasprintf\\|strerror\\|strdup\\|asprintf\\|sprintf\\)[ ]*\(\\)" 1 font-lock-warning-face t))))
+(add-hook 'c-mode-common-hook 'gdb-fun-name-hook)
+
+;; Don't include these files directly.
+(defun gdb-include-hook ()
+  (font-lock-add-keywords
+   nil
+   '(("\\<include[ ]*\\(<\\(sys/stat\\|stat\\|dirent\\|wait\\|sys/wait\\|assert\\)\\.h>\\)" 1 font-lock-warning-face t))))
+
+(add-hook 'c-mode-common-hook 'gdb-include-hook)
+
+;;; gdb-code-style.el ends here
-- 
1.7.0.4


      reply	other threads:[~2012-04-19  2:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-14  7:46 Yao Qi
2012-04-14 12:24 ` Eli Zaretskii
2012-04-16 20:01 ` Tom Tromey
2012-04-19  4:14   ` Yao Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8F722D.40603@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox