From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24819 invoked by alias); 16 Apr 2012 19:11:02 -0000 Received: (qmail 24810 invoked by uid 22791); 16 Apr 2012 19:11:01 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Apr 2012 19:10:43 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3GJAePf002529 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Apr 2012 15:10:40 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3GIHaWa020713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 16 Apr 2012 14:17:37 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Check code stype in Emacs: gdb-code-style.el References: <1334378614-13787-1-git-send-email-yao@codesourcery.com> Date: Mon, 16 Apr 2012 20:01:00 -0000 In-Reply-To: <1334378614-13787-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Sat, 14 Apr 2012 12:43:34 +0800") Message-ID: <8762cz1qyn.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00429.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> gdb-code-style.el gives some checks, and highlight corresponding parts Yao> if they are violations on a certain rule or convention in gdb development. Yao> So far, it only has two, and I'd like to push more, if it is the right Yao> way to go. Super, let's do it. Yao> diff --git a/gdb/gdb-code-style.el b/gdb/gdb-code-style.el Yao> new file mode 100644 Yao> index 0000000..5919e3d Yao> --- /dev/null Yao> +++ b/gdb/gdb-code-style.el Yao> @@ -0,0 +1,35 @@ Yao> +;; Emacs settings to check various code styles. Yao> +;; Copyright (C) 2012 Free Software Foundation, Inc. Could you make this conform to the elisp comment-header guidelines? See (info "(elisp) Library Headers"). With this change people can M-x package-install-file the .el if they want. (In fact that is a decent way to test the headers; package.el is kind of picky about the formatting.) Ok with that change. Tom