From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] more constification
Date: Fri, 13 Jun 2014 16:52:00 -0000 [thread overview]
Message-ID: <8761k4pxah.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5399A554.6060708@redhat.com> (Pedro Alves's message of "Thu, 12 Jun 2014 14:04:20 +0100")
Pedro> A couple nits I noticed:
Pedro> - The subject of patch #3 sounds like something you'd have
Pedro> in a local branch. Should that patch be merged with some
Pedro> other in the series? Does GDB build at each step of the
Pedro> series?
Yes, it does.
I fixed the subject. Sorry about that.
Pedro> - A typo in the log of patch #6: "SO".
Fixed.
Tom
next prev parent reply other threads:[~2014-06-13 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 18:53 Tom Tromey
2014-06-11 18:53 ` [PATCH 2/7] constify probe.c function Tom Tromey
2014-06-11 18:53 ` [PATCH 6/7] constify some blockvector APIs Tom Tromey
2014-06-11 18:53 ` [PATCH 4/7] remove unneeded cast in symtab.c Tom Tromey
2014-06-11 18:53 ` [PATCH 3/7] fix up parse_cli_boolean_value after rebase Tom Tromey
2014-06-11 18:53 ` [PATCH 1/7] constify struct block in some places Tom Tromey
2014-06-11 19:46 ` [PATCH 5/7] constify complete_line Tom Tromey
2014-06-11 19:48 ` [PATCH 7/7] make common_block const Tom Tromey
2014-06-12 8:45 ` [PATCH 0/7] more constification Joel Brobecker
2014-06-13 16:50 ` Tom Tromey
2014-06-13 19:01 ` Maciej W. Rozycki
2014-06-23 13:25 ` Joel Brobecker
2014-06-30 8:55 ` Maciej W. Rozycki
2014-07-07 14:27 ` Joel Brobecker
2014-06-12 13:04 ` Pedro Alves
2014-06-13 16:52 ` Tom Tromey [this message]
2014-06-18 14:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761k4pxah.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox