From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] more constification
Date: Thu, 12 Jun 2014 13:04:00 -0000 [thread overview]
Message-ID: <5399A554.6060708@redhat.com> (raw)
In-Reply-To: <1402512797-6082-1-git-send-email-tromey@redhat.com>
On 06/11/2014 07:53 PM, Tom Tromey wrote:
> This series constifies a few more things in gdb.
>
> A few of the patches are very basic and #4 is downright trivial.
>
> Patch #6 casts away const in a couple spots. There's a justification
> in the patch; but I also wanted to add that the casts only affect
> mdebugread.c, which can't really be said to be actively maintained in
> any case.
>
> Some of these patches are part of a larger work to constify the
> argument pass to gdb commands. This longer series isn't finished yet;
> but it simplifies to the work to put patches in bottom-up and mildly
> improves gdb in the process.
Looked fine to me.
A couple nits I noticed:
- The subject of patch #3 sounds like something you'd have
in a local branch. Should that patch be merged with some
other in the series? Does GDB build at each step of the
series?
- A typo in the log of patch #6: "SO".
--
Pedro Alves
next prev parent reply other threads:[~2014-06-12 13:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 18:53 Tom Tromey
2014-06-11 18:53 ` [PATCH 1/7] constify struct block in some places Tom Tromey
2014-06-11 18:53 ` [PATCH 3/7] fix up parse_cli_boolean_value after rebase Tom Tromey
2014-06-11 18:53 ` [PATCH 6/7] constify some blockvector APIs Tom Tromey
2014-06-11 18:53 ` [PATCH 4/7] remove unneeded cast in symtab.c Tom Tromey
2014-06-11 18:53 ` [PATCH 2/7] constify probe.c function Tom Tromey
2014-06-11 19:46 ` [PATCH 5/7] constify complete_line Tom Tromey
2014-06-11 19:48 ` [PATCH 7/7] make common_block const Tom Tromey
2014-06-12 8:45 ` [PATCH 0/7] more constification Joel Brobecker
2014-06-13 16:50 ` Tom Tromey
2014-06-13 19:01 ` Maciej W. Rozycki
2014-06-23 13:25 ` Joel Brobecker
2014-06-30 8:55 ` Maciej W. Rozycki
2014-07-07 14:27 ` Joel Brobecker
2014-06-12 13:04 ` Pedro Alves [this message]
2014-06-13 16:52 ` Tom Tromey
2014-06-18 14:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399A554.6060708@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox