From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] more constification
Date: Fri, 13 Jun 2014 16:50:00 -0000 [thread overview]
Message-ID: <87a99gpxd0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20140612084534.GC4730@adacore.com> (Joel Brobecker's message of "Thu, 12 Jun 2014 10:45:34 +0200")
Tom> Patch #6 casts away const in a couple spots. There's a justification
Tom> in the patch; but I also wanted to add that the casts only affect
Tom> mdebugread.c, which can't really be said to be actively maintained in
Tom> any case.
Joel> I am wondering whether we should consider the option of deprecating
Joel> those targets that use this code. This affects alpha-tru64 and
Joel> maybe mips-linux (although - is that option still supported by
Joel> GCC? And even if it was, who would want to use that object format
Joel> instead of ELF???). It's also said to be used by some versions
Joel> of IRIX, but I am not sure that GDB works on those - the ones
Joel> we've been supporting until a few years ago were using ELF.
There was this thread:
https://www.sourceware.org/ml/gdb/2012-12/msg00052.html
I somewhat recall looking into removing some of this code (I don't
remember if it was mdebugread or something else) and finding to my
dismay that it was intertwined with other somewhat more living code in a
way that made it hard to untangle. I thought I sent a note about this,
but I can't find it now.
I'm generally in favor of removing things. gdb has too much moribund
code. However it's not always easy to tell what is really dying, and
one is less likely to get complaints about a patch than a removal.
Perhaps at some point we can say it is either definitively dead or
definitively broken (like the solib-sunos stuff last year) and then
remove it.
Tom
next prev parent reply other threads:[~2014-06-13 16:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 18:53 Tom Tromey
2014-06-11 18:53 ` [PATCH 2/7] constify probe.c function Tom Tromey
2014-06-11 18:53 ` [PATCH 6/7] constify some blockvector APIs Tom Tromey
2014-06-11 18:53 ` [PATCH 4/7] remove unneeded cast in symtab.c Tom Tromey
2014-06-11 18:53 ` [PATCH 3/7] fix up parse_cli_boolean_value after rebase Tom Tromey
2014-06-11 18:53 ` [PATCH 1/7] constify struct block in some places Tom Tromey
2014-06-11 19:46 ` [PATCH 5/7] constify complete_line Tom Tromey
2014-06-11 19:48 ` [PATCH 7/7] make common_block const Tom Tromey
2014-06-12 8:45 ` [PATCH 0/7] more constification Joel Brobecker
2014-06-13 16:50 ` Tom Tromey [this message]
2014-06-13 19:01 ` Maciej W. Rozycki
2014-06-23 13:25 ` Joel Brobecker
2014-06-30 8:55 ` Maciej W. Rozycki
2014-07-07 14:27 ` Joel Brobecker
2014-06-12 13:04 ` Pedro Alves
2014-06-13 16:52 ` Tom Tromey
2014-06-18 14:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a99gpxd0.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox