From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8249 invoked by alias); 13 Jun 2014 16:52:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8236 invoked by uid 89); 13 Jun 2014 16:52:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jun 2014 16:52:09 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5DGq7iu020269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 13 Jun 2014 12:52:07 -0400 Received: from barimba (ovpn-113-103.phx2.redhat.com [10.3.113.103]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5DGq6Td027723 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 13 Jun 2014 12:52:07 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] more constification References: <1402512797-6082-1-git-send-email-tromey@redhat.com> <5399A554.6060708@redhat.com> Date: Fri, 13 Jun 2014 16:52:00 -0000 In-Reply-To: <5399A554.6060708@redhat.com> (Pedro Alves's message of "Thu, 12 Jun 2014 14:04:20 +0100") Message-ID: <8761k4pxah.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-06/txt/msg00534.txt.bz2 Pedro> A couple nits I noticed: Pedro> - The subject of patch #3 sounds like something you'd have Pedro> in a local branch. Should that patch be merged with some Pedro> other in the series? Does GDB build at each step of the Pedro> series? Yes, it does. I fixed the subject. Sorry about that. Pedro> - A typo in the log of patch #6: "SO". Fixed. Tom