[pushed] gdb: remove TYPE_INCOMPLETE

[pushed] gdb: remove TYPE_INCOMPLETE

[Simon Marchi]

The "HP platforms" comment prompted me to check if this was still used
somewhere.  Apparently it's not, so remove it.

gdb/ChangeLog:

	* gdbtypes.h (TYPE_INCOMPLETE): Remove.
	* gdbtypes.c (recursive_dump_type): Remove use of
	TYPE_INCOMPLETE.
---
 gdb/ChangeLog  |  6 ++++++
 gdb/gdbtypes.c |  4 ----
 gdb/gdbtypes.h | 10 ----------
 3 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9a611ae939d9..ff528ba9ebef 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
+
+	* gdbtypes.h (TYPE_INCOMPLETE): Remove.
+	* gdbtypes.c (recursive_dump_type): Remove use of
+	TYPE_INCOMPLETE.
+
 2020-05-03  Tom Tromey  <tom@tromey.com>
 
 	* breakpoint.c (catch_command, tcatch_command): Remove.
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 93ef8774a915..9a6a6dd74b10 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -5080,10 +5080,6 @@ recursive_dump_type (struct type *type, int spaces)
     {
       puts_filtered (" TYPE_PROTOTYPED");
     }
-  if (TYPE_INCOMPLETE (type))
-    {
-      puts_filtered (" TYPE_INCOMPLETE");
-    }
   if (TYPE_VARARGS (type))
     {
       puts_filtered (" TYPE_VARARGS");
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 8899fb151191..e231f495ab7a 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -246,16 +246,6 @@ DEF_ENUM_FLAGS_TYPE (enum type_instance_flag_value, type_instance_flags);
 
 #define TYPE_PROTOTYPED(t)	(TYPE_MAIN_TYPE (t)->flag_prototyped)
 
-/* * This flag is used to indicate that processing for this type
-   is incomplete.
-
-   (Mostly intended for HP platforms, where class methods, for
-   instance, can be encountered before their classes in the debug
-   info; the incomplete type has to be marked so that the class and
-   the method can be assigned correct types.)  */
-
-#define TYPE_INCOMPLETE(t)	(TYPE_MAIN_TYPE (t)->flag_incomplete)
-
 /* * FIXME drow/2002-06-03:  Only used for methods, but applies as well
    to functions.  */
 
-- 
2.26.2

Re: [pushed] gdb: remove TYPE_INCOMPLETE

[Tom Tromey]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> -#define TYPE_INCOMPLETE(t)	(TYPE_MAIN_TYPE (t)->flag_incomplete)

I think the flag_incomplete field could be removed as well.

Tom

Re: [pushed] gdb: remove TYPE_INCOMPLETE

[Simon Marchi]

On 2020-05-05 4:21 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> -#define TYPE_INCOMPLETE(t)	(TYPE_MAIN_TYPE (t)->flag_incomplete)
> 
> I think the flag_incomplete field could be removed as well.

Doh, of course.  I just pushed this patch.


From a3bbacc120892759fa364d61471195275541c2be Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@efficios.com>
Date: Tue, 5 May 2020 16:59:32 -0400
Subject: [PATCH] gdb: remove main_type::flag_incomplete

It is unused.  The corresponding macro was removed in c3236f84c17 ("gdb:
remove TYPE_INCOMPLETE").

gdb/ChangeLog:

	* gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
---
 gdb/ChangeLog  | 4 ++++
 gdb/gdbtypes.h | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ff528ba9ebef..dd29c7534953 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
+
+	* gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
+
 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>

 	* gdbtypes.h (TYPE_INCOMPLETE): Remove.
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index e231f495ab7a..4e95a6021817 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -765,7 +765,6 @@ struct main_type
   unsigned int flag_target_stub : 1;
   unsigned int flag_static : 1;
   unsigned int flag_prototyped : 1;
-  unsigned int flag_incomplete : 1;
   unsigned int flag_varargs : 1;
   unsigned int flag_vector : 1;
   unsigned int flag_stub_supported : 1;
-- 
2.26.2