From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 77B1438930DF for ; Tue, 5 May 2020 21:00:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 77B1438930DF Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id C1D142A21EB; Tue, 5 May 2020 17:00:56 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 48dsC9ZrBIBq; Tue, 5 May 2020 17:00:56 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 8E8862A21E9; Tue, 5 May 2020 17:00:56 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 8E8862A21E9 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AoVU0fuwp1yn; Tue, 5 May 2020 17:00:56 -0400 (EDT) Received: from [10.0.0.193] (unknown [192.222.164.54]) by mail.efficios.com (Postfix) with ESMTPSA id 77A3C2A2347; Tue, 5 May 2020 17:00:56 -0400 (EDT) Subject: Re: [pushed] gdb: remove TYPE_INCOMPLETE To: Tom Tromey , Simon Marchi via Gdb-patches References: <20200505025317.1648302-1-simon.marchi@efficios.com> <875zda9lpy.fsf@tromey.com> From: Simon Marchi Message-ID: <13857fb5-34c5-8706-b9cb-58919c19584f@efficios.com> Date: Tue, 5 May 2020 17:00:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <875zda9lpy.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2020 21:00:58 -0000 On 2020-05-05 4:21 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> -#define TYPE_INCOMPLETE(t) (TYPE_MAIN_TYPE (t)->flag_incomplete) > > I think the flag_incomplete field could be removed as well. Doh, of course. I just pushed this patch. >From a3bbacc120892759fa364d61471195275541c2be Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 5 May 2020 16:59:32 -0400 Subject: [PATCH] gdb: remove main_type::flag_incomplete It is unused. The corresponding macro was removed in c3236f84c17 ("gdb: remove TYPE_INCOMPLETE"). gdb/ChangeLog: * gdbtypes.h (struct main_type) : Remove. --- gdb/ChangeLog | 4 ++++ gdb/gdbtypes.h | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ff528ba9ebef..dd29c7534953 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-05-05 Simon Marchi + + * gdbtypes.h (struct main_type) : Remove. + 2020-05-04 Simon Marchi * gdbtypes.h (TYPE_INCOMPLETE): Remove. diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index e231f495ab7a..4e95a6021817 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -765,7 +765,6 @@ struct main_type unsigned int flag_target_stub : 1; unsigned int flag_static : 1; unsigned int flag_prototyped : 1; - unsigned int flag_incomplete : 1; unsigned int flag_varargs : 1; unsigned int flag_vector : 1; unsigned int flag_stub_supported : 1; -- 2.26.2