From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: restore nullptr check in compunit_symtab::find_call_site
Date: Tue, 03 Dec 2024 12:43:33 -0700 [thread overview]
Message-ID: <875xo0mu1m.fsf@tromey.com> (raw)
In-Reply-To: <8cf13692-d876-43d1-bdf1-08cf4429d177@simark.ca> (Simon Marchi's message of "Tue, 3 Dec 2024 14:11:23 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> On the one hand, obstacks are nice since they reduce free overhead.
>> But on the other hand, they mean we can't use destructors... and for
>> this case, I think there normally aren't "too many" symtabs, so it's
>> probably fine to make the change.
Simon> We can still use destructors, we might just need to call it manually.
Yeah, that just doesn't seem significantly better to me. It is more
like a spelling change.
Tom
next prev parent reply other threads:[~2024-12-03 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 15:52 Simon Marchi
2024-12-03 16:17 ` Tom de Vries
2024-12-03 19:19 ` Simon Marchi
2024-12-03 17:49 ` Tom Tromey
2024-12-03 19:11 ` Simon Marchi
2024-12-03 19:43 ` Tom Tromey [this message]
2024-12-03 20:05 ` Simon Marchi
2024-12-03 20:15 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xo0mu1m.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox