From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8NOLD5BfT2eY6gIAWB0awg (envelope-from ) for ; Tue, 03 Dec 2024 14:44:16 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=i538hLcZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3C0EB1E0BB; Tue, 3 Dec 2024 14:44:16 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D60D51E05C for ; Tue, 3 Dec 2024 14:44:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6BA503858CDA for ; Tue, 3 Dec 2024 19:44:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6BA503858CDA Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=i538hLcZ Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 2C4D13858D26 for ; Tue, 3 Dec 2024 19:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C4D13858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C4D13858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733255017; cv=none; b=fnk5y5SKH1vj8FodfBb2za/koY0AyfkLtnKU/G6GMkMKyWxcrtyykfYvYk8VQhRltVIiwPRjstvJr8hEXjDVXklDrxO31zd6vmwnYiNAnnAubNz0VnozjtSdeOnfxjEAPAve5cu/FxsxlOgUwxkkDO5/5AKDelnXRasPtZauZ+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1733255017; c=relaxed/simple; bh=HiKyzHrasI7KZVDTLVndBW7Z/ULFWvlHD74kIrXpxag=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Zr485CuCaH+fr/U7Ox+L+d14rHIVTktfzscCJ2+C3AADZtc/ByygwGJZwiOw/+n2WUit7NNApLf18nfD9bOOPiqwb8Al4orlroZjYxJxW5pCzJC2iiF5jEIfGfWvmYScQnfZJOMB9/T7QCwShoK07QUwBQjD76jGkjWBIl1BZ2A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C4D13858D26 Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id IWIXttMdCvH7lIYo4tklGK; Tue, 03 Dec 2024 19:43:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id IYo2tVaVK2Zy0IYo3t3Duc; Tue, 03 Dec 2024 19:43:35 +0000 X-Authority-Analysis: v=2.4 cv=Q4EZ4J2a c=1 sm=1 tr=0 ts=674f5f67 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RZcAm9yDv7YA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=b4z3m-pzePNLAxBnvmQA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j52jvZLY4iGVVlYIpnXK+ZvqJaFiLk+PySRykDAc+oY=; b=i538hLcZ7V8HzINju2KtcpZhVg im0SFPH6esMHi6dLjLacm2zj5tXNgim67Knavdfb5tN4+qilSOsnDME2BJ0q3fWi0eBYuqAZIMDlu YCWfPCSpa6ShP1FuJy9D2AP8B; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:50048 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tIYo2-002Q3l-1p; Tue, 03 Dec 2024 12:43:34 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: restore nullptr check in compunit_symtab::find_call_site In-Reply-To: <8cf13692-d876-43d1-bdf1-08cf4429d177@simark.ca> (Simon Marchi's message of "Tue, 3 Dec 2024 14:11:23 -0500") References: <20241203155223.10203-1-simon.marchi@efficios.com> <87ser4mzbr.fsf@tromey.com> <8cf13692-d876-43d1-bdf1-08cf4429d177@simark.ca> X-Attribution: Tom Date: Tue, 03 Dec 2024 12:43:33 -0700 Message-ID: <875xo0mu1m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1tIYo2-002Q3l-1p X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (murgatroyd) [97.122.113.155]:50048 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHbP67picZ+26UxkIHsgqWegQlr/AjuOpHQoPNfMo0Jd3eccHBkZfEe2KZ4Uw2DLMXTo1mb4dvKo1gG+wzTQMh2coZGAtZ/soGn5B2JWTA2Kd7Zv/1yq 6kAxPuONrWkh9oKrs577/sKt7ZVBQ67A3PljuXqDpDrROgtyy2eJP43aekCV8KR/ShL6ul+Cmq9OjpRyPHqlYVsNbYpGvZR/YIg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> On the one hand, obstacks are nice since they reduce free overhead. >> But on the other hand, they mean we can't use destructors... and for >> this case, I think there normally aren't "too many" symtabs, so it's >> probably fine to make the change. Simon> We can still use destructors, we might just need to call it manually. Yeah, that just doesn't seem significantly better to me. It is more like a spelling change. Tom