Re: [PATCH] gdb: restore nullptr check in compunit_symtab::find_call_site

[Simon Marchi <simark@simark.ca>]

On 2024-12-03 14:43, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
> 
>>> On the one hand, obstacks are nice since they reduce free overhead.
>>> But on the other hand, they mean we can't use destructors... and for
>>> this case, I think there normally aren't "too many" symtabs, so it's
>>> probably fine to make the change.
> 
> Simon> We can still use destructors, we might just need to call it manually.
> 
> Yeah, that just doesn't seem significantly better to me.  It is more
> like a spelling change.

I don't think it's just a spelling change, because a destructor would
invoke the destructor of fields.  So I think that if we started invoking
~compunit_symtab() manually (instead of compunit_symtab::finalize()),
we could start using non-trivially-destructible stuff directly as fields
of compunit_symtab.  In other words, m_call_site_htab wouldn't have to
be a pointer anymore.

Simon