Re: [PATCH] gdb: restore nullptr check in compunit_symtab::find_call_site

[Simon Marchi <simark@simark.ca>]

On 2024-12-03 11:17, Tom de Vries wrote:
> On 12/3/24 16:52, Simon Marchi wrote:
>> Commit de2b4ab50de ("Convert dwarf2_cu::call_site_htab to new hash
>> table") removed this nullptr check for no good reason.  This causes a
>> crash if `m_call_site_htab` is not set, as shown in PR 32410.  My guess
>> is that when doing this change, I tried to make `m_call_site_htab` not a
>> pointer, removed this check, then realized it wasn't so obvious, and
>> forgot to re-add the check.
>>
> 
> Hi Simon,
> 
> thanks for the quick fix.
> 
> I've tested it with the test-case on which the PR was reported, and gdb no longer crashes.  The test-case still produces two FAILs, but that looks unrelated.
> 
> LGTM.
> 
> Approved-By: Tom de Vries <tdevries@suse.de>

Thanks,  pushed.

Simon