Re: [PATCH v2 3/6] gdb/record: c++ify internal structures of record-full.c

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Guinevere Larsen <guinevere@redhat.com> writes:

> This commit adds a constructor, destructor, and some methods to the
> structures record_full_entry, record_full_reg_entry and
> record_full_mem_entry. This is a move to disentangle the internal
> representation of the data and how record-full manipulates it for
> replaying.
>
> Along with this change, record_full_entry is changed to use an
> std::variant, since it was basically doing that already, but now we have
> the stdlibc++ error checking to make sure we're only accessing elements
> we're allowed to.
> ---
>  gdb/record-full.c | 553 ++++++++++++++++++++++++----------------------
>  1 file changed, 289 insertions(+), 264 deletions(-)

Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>

-- 
Thiago