From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8bHGFLcp8GlSyz8AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 23:29:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=yfedVcUC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 50F961E093; Mon, 27 Apr 2026 23:29:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7B4771E093 for ; Mon, 27 Apr 2026 23:29:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id EFEBC4BABF1D for ; Tue, 28 Apr 2026 03:29:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFEBC4BABF1D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=yfedVcUC Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by sourceware.org (Postfix) with ESMTPS id D41BB4B9DB74 for ; Tue, 28 Apr 2026 03:29:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D41BB4B9DB74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D41BB4B9DB74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777346968; cv=none; b=CTCe7CHzqdSyYDL4QFin5zTgFPIRM2UHNotZnuBW7hs8dim51fKb4R1+Yx8vBtQgQVz/yiPQGoJ4yCj+DvJww01xxFoHMBwfBabCkowKlHuqvdzHqyCKh2weuLBhFRS9mKZpWDJXFD+INaV4OVnKa9faeL1kuqc8vXKLIVwPTx4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777346968; c=relaxed/simple; bh=GdUfyiFek5l8ASoIyhVN3E1Uuj2xXsNXQ0jdWAUK4Ak=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xk7kjGcAXXPZIech4rRyJ7SmAxU/eLYbob1cU/eEvwoHJU90arhOQXgvQYzdaYSin5zyQmnaWmd6LN4bIqAd3WYMNNw1Vlj3vxq59l43qusqF2dMMesC/35lyW7IrnAKcJhBKflY8IhJ8sXNMDdOus3U3amqTmU5OagCzI85+Ms= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D41BB4B9DB74 Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-79ee5037d44so146287537b3.0 for ; Mon, 27 Apr 2026 20:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777346968; x=1777951768; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=20/VhrpP9OXvx1KhMoQhvhHwUH4IXYQh8Rk7zPnwU/k=; b=yfedVcUCXAuZm4hD+tc9zjeYn6SLD03WWUY40toVDM5DPG6bxzpyW24SCleGvAfB1R liPiV3CyWw7tgz7TkLz+Lfm8Y2sbvtZBppU68eV9tnSFTtGWcI3Lbj2pcriEzGInj5IE DO/tHcx2rg5QSw1P5QO8qi80FvsznJEetk/jrbK5g4DeNvSOvPvIQICnRZtIthTROnCd P+UOxt7u6PsSC9V6qkfy1QG2AhGYdxcC6/ytJxl/O7YxIV6rp07greTw78AQZNBbeMIZ gst4n3ZEJIEfmS+fJ7AnoAz/qWmXoI6F85/W+WWQ5fIz2rIXIJZU0ZB1mH5eegLqeOhB s9kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777346968; x=1777951768; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=20/VhrpP9OXvx1KhMoQhvhHwUH4IXYQh8Rk7zPnwU/k=; b=lN94FtxzLs/ulEgy9Uk9mcW1c/l/GojkIZ9vxTX8MAYwyC5bDooMKW/QziZMfq/vEr EKOtWtx+B/mwBTm1+cKxdOBvAylkHdTulLd2rv3/CdvUX7zYA2W9Sw5GsEQYqWRN1o9P 9l2jmDFDX+CPONY6rwRE0LWgD+yZekG3faFe5N6d/YhfcGu6ddJHu8thiPbhrOYrgf9l LmkVsDhT+8mUbCgiQsj993Dy9gb7jb39Sv/PWTiqHGcdCAaKCgYlovclLSFZKcVVo0Vk rgW4pEDZTM4488oWzUme1lyypDMtU+xJ+cfEtSBIRhytcAlDTFFM64GPli18gFCWSvI4 iCiw== X-Gm-Message-State: AOJu0YwnWCph/7wxVDPHYpCKhrGmsaZguaKyvsHtsF1NUK9ciMWxcTWt 62zJnKbv5/QM09CL1rqr9GX2hxmzsRmLDP9+GG2q44D3nvlife1f6HXixIKRr+dUXUdQBYpHUWT pok5y X-Gm-Gg: AeBDietqldaxsNr5ii6x8ZRb9y3uKrORgqgi04YGLmTu2UFJCIuHtCaqC/XwJd3XAf8 q2aeHh+tseXm3A2ujdaewTMHTo2jr59MVpbfzYYlAirO2e4JxZWmPjNiiL0u37MhL1dmHhiQqYT HKn7sqFoMoPY4TqR3PoZJdRWSC/RS+V68fXDrZx05vvGwoocdoflMyD4YRzU6+PPnAWG/qShEnS rmv1l8Iq2bWHvhUjeupNzVFDtfY3SLfjFoKIIW0YFcrydKa3RLlrTtCIbbeJo81aWr1mlLViycB EJwyw3bFq76wHUAR68XmDedHQy7gpV2TKiUAAT2vhwbbnkIAhzF9z4SoWJc4w/ROh8VI27syXiv uHg/P2r00oyWSVpCLZ/O1piUxqnCLMHddXV0H+5bbsY1Npba+Qi+oDbHsD2viFvGW1S26vDr5+a OJo+PTRo/navmPi8iadpQG5cJ36OCP4FAsbhwxUJseKMwR X-Received: by 2002:a05:690c:c4e8:b0:7b4:1394:4104 with SMTP id 00721157ae682-7bcf2ffd31emr12115927b3.9.1777346968092; Mon, 27 Apr 2026 20:29:28 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bcf04bc8c0sm8758427b3.2.2026.04.27.20.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 20:29:27 -0700 (PDT) From: Thiago Jung Bauermann To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/6] gdb/record: c++ify internal structures of record-full.c In-Reply-To: <20260423152604.171356-4-guinevere@redhat.com> (Guinevere Larsen's message of "Thu, 23 Apr 2026 12:26:01 -0300") References: <20260423152604.171356-1-guinevere@redhat.com> <20260423152604.171356-4-guinevere@redhat.com> User-Agent: mu4e 1.14.0; emacs 30.2 Date: Tue, 28 Apr 2026 00:29:25 -0300 Message-ID: <875x5blq3u.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > This commit adds a constructor, destructor, and some methods to the > structures record_full_entry, record_full_reg_entry and > record_full_mem_entry. This is a move to disentangle the internal > representation of the data and how record-full manipulates it for > replaying. > > Along with this change, record_full_entry is changed to use an > std::variant, since it was basically doing that already, but now we have > the stdlibc++ error checking to make sure we're only accessing elements > we're allowed to. > --- > gdb/record-full.c | 553 ++++++++++++++++++++++++---------------------- > 1 file changed, 289 insertions(+), 264 deletions(-) Reviewed-by: Thiago Jung Bauermann -- Thiago