Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Berlin <dan@cgsoftware.com>
To: Per Bothner <per@bothner.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: obvious set_cu_language patch
Date: Thu, 07 Jun 2001 23:50:00 -0000	[thread overview]
Message-ID: <874rtrjwis.fsf@cgsoftware.com> (raw)
In-Reply-To: <m24rtrwkfd.fsf@kelso.bothner.com>

Per Bothner <per@bothner.com> writes:

> I consider this one fairly obvious.
> 

Yup. I swear the java guys submitted this before, and we accepted and
committed it.
I know it was submitted *ages* ago.


Ahh, here's the problem with it:
dwarf2.h in gcc defines DW_LANG_Java as 0x000b.
binutils/gdb's include/elf/dwarf2.h defines DW_LANG_Java as 0x9af4

Which is correct?
Please, in addition to committing this patch, which *is* an obvious
fix, fix whichever one of the two above is wrong.

Clearly, one is.

Please tell me it's the include/elf/dwarf2.h, and not gcc, because if
it's gcc, we have to handle *both* in gdb.

> 2001-06-07  Per Bothner  <per@bothner.com>
> 
> 	* dwarf2read.c (set_cu_language):  Handle DW_LANG_Java.
> 
> Index: dwarf2read.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dwarf2read.c,v
> retrieving revision 1.24
> diff -u -r1.24 dwarf2read.c
> --- dwarf2read.c	2001/04/30 10:30:27	1.24
>+++ dwarf2read.c	2001/06/08 06:18:51
> @@ -3721,6 +3721,9 @@
>      case DW_LANG_Mips_Assembler:
>        cu_language = language_asm;
>        break;
>+    case DW_LANG_Java:
>+      cu_language = language_java;
>+      break;
>      case DW_LANG_Ada83:
>      case DW_LANG_Cobol74:
>      case DW_LANG_Cobol85:
> 
> -- 
> 	--Per Bothner
> per@bothner.com   http://www.bothner.com/per/

-- 
"I was born by Caesarean section...  But not so you'd notice.
It's just that when I leave a house, I go out through the
window.
"-Steven Wright


  reply	other threads:[~2001-06-07 23:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-07 23:22 Per Bothner
2001-06-07 23:50 ` Daniel Berlin [this message]
2001-06-08 11:01   ` Per Bothner
2001-06-08 14:04     ` Stan Shebs
2001-06-08 14:34       ` Daniel Berlin
2001-06-08 13:04 ` Andrew Cagney
     [not found]   ` <m2pucevgf6.fsf@kelso.bothner.com>
2001-06-08 13:51     ` Daniel Berlin
     [not found]       ` <8766e6eke4.fsf@creche.redhat.com>
2001-06-08 14:23         ` Per Bothner
     [not found]       ` <npelsq28sh.fsf_-_@zwingli.cygnus.com>
2001-06-11 11:43         ` Rewriting the type system Daniel Berlin
2001-06-11 16:58           ` Stan Shebs
2001-06-12  1:44           ` Eli Zaretskii
2001-06-12  9:12             ` Daniel Berlin
2001-06-12 10:01               ` Eli Zaretskii
2001-06-12 10:16           ` Jim Blandy
2001-06-12 10:44             ` Daniel Berlin
2001-06-12 14:02               ` Stan Shebs
2001-06-13  1:45                 ` Eli Zaretskii
2001-06-12 11:08             ` Daniel Berlin
2001-06-12 14:03           ` Andrew Cagney
2001-06-12 21:37             ` Daniel Berlin
2001-06-25 14:13 ` obvious set_cu_language patch Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874rtrjwis.fsf@cgsoftware.com \
    --to=dan@cgsoftware.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=per@bothner.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox