From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Berlin To: Per Bothner Cc: gdb-patches@sources.redhat.com Subject: Re: obvious set_cu_language patch Date: Thu, 07 Jun 2001 23:50:00 -0000 Message-id: <874rtrjwis.fsf@cgsoftware.com> References: X-SW-Source: 2001-06/msg00165.html Per Bothner writes: > I consider this one fairly obvious. > Yup. I swear the java guys submitted this before, and we accepted and committed it. I know it was submitted *ages* ago. Ahh, here's the problem with it: dwarf2.h in gcc defines DW_LANG_Java as 0x000b. binutils/gdb's include/elf/dwarf2.h defines DW_LANG_Java as 0x9af4 Which is correct? Please, in addition to committing this patch, which *is* an obvious fix, fix whichever one of the two above is wrong. Clearly, one is. Please tell me it's the include/elf/dwarf2.h, and not gcc, because if it's gcc, we have to handle *both* in gdb. > 2001-06-07 Per Bothner > > * dwarf2read.c (set_cu_language): Handle DW_LANG_Java. > > Index: dwarf2read.c > =================================================================== > RCS file: /cvs/src/src/gdb/dwarf2read.c,v > retrieving revision 1.24 > diff -u -r1.24 dwarf2read.c > --- dwarf2read.c 2001/04/30 10:30:27 1.24 >+++ dwarf2read.c 2001/06/08 06:18:51 > @@ -3721,6 +3721,9 @@ > case DW_LANG_Mips_Assembler: > cu_language = language_asm; > break; >+ case DW_LANG_Java: >+ cu_language = language_java; >+ break; > case DW_LANG_Ada83: > case DW_LANG_Cobol74: > case DW_LANG_Cobol85: > > -- > --Per Bothner > per@bothner.com http://www.bothner.com/per/ -- "I was born by Caesarean section... But not so you'd notice. It's just that when I leave a house, I go out through the window. "-Steven Wright