From: Eli Zaretskii <eliz@is.elta.co.il>
To: shebs@apple.com
Cc: dan@cgsoftware.com, jimb@zwingli.cygnus.com,
gdb-patches@sources.redhat.com
Subject: Re: Rewriting the type system
Date: Wed, 13 Jun 2001 01:45:00 -0000 [thread overview]
Message-ID: <200106130846.LAA16348@is.elta.co.il> (raw)
In-Reply-To: <3B268089.D5839A84@apple.com>
> Date: Tue, 12 Jun 2001 13:50:16 -0700
> From: Stan Shebs <shebs@apple.com>
>
> Both of you are in the wrong here. Jim, you know as well as anyone
> that the C++ symbol handling parts of GDB are not so neatly partitioned
> that you can review symbol patches without knowing more than a bit about
> C++, and Dan, you should be able to admit mistakes in your patches, fix
> them and resubmit, rather than flaming the reviewer of the patch.
>
> There is plenty of room to criticize both maintainer responsiveness
> and patch quality without turning it into a spitting match, and I'm
> disappointed to see the development process sink to this level.
I agree 110%.
Exchanging accusations will get us nowehere; and if Dan feels his
patches are consistently ignored, then something is not right in the
process of reviewing those patches and providing relevant feedback
back to Dan.
In particular, if there are aspects in Dan's (or anybody else's) code
that the maintainer wants changed, then those aspects should be
pointed out. I know I had such comments on my submissions from time
to time, and I'm sure everyone else had as well.
But leaving patches unreviwed or the person who submitted them in an
uncertain state is something that I think should be avoided at all
costs.
next prev parent reply other threads:[~2001-06-13 1:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-07 23:22 obvious set_cu_language patch Per Bothner
2001-06-07 23:50 ` Daniel Berlin
2001-06-08 11:01 ` Per Bothner
2001-06-08 14:04 ` Stan Shebs
2001-06-08 14:34 ` Daniel Berlin
2001-06-08 13:04 ` Andrew Cagney
[not found] ` <m2pucevgf6.fsf@kelso.bothner.com>
2001-06-08 13:51 ` Daniel Berlin
[not found] ` <8766e6eke4.fsf@creche.redhat.com>
2001-06-08 14:23 ` Per Bothner
[not found] ` <npelsq28sh.fsf_-_@zwingli.cygnus.com>
2001-06-11 11:43 ` Rewriting the type system Daniel Berlin
2001-06-11 16:58 ` Stan Shebs
2001-06-12 1:44 ` Eli Zaretskii
2001-06-12 9:12 ` Daniel Berlin
2001-06-12 10:01 ` Eli Zaretskii
2001-06-12 10:16 ` Jim Blandy
2001-06-12 10:44 ` Daniel Berlin
2001-06-12 14:02 ` Stan Shebs
2001-06-13 1:45 ` Eli Zaretskii [this message]
2001-06-12 11:08 ` Daniel Berlin
2001-06-12 14:03 ` Andrew Cagney
2001-06-12 21:37 ` Daniel Berlin
2001-06-25 14:13 ` obvious set_cu_language patch Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200106130846.LAA16348@is.elta.co.il \
--to=eliz@is.elta.co.il \
--cc=dan@cgsoftware.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@zwingli.cygnus.com \
--cc=shebs@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox