Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Berlin <dan@cgsoftware.com>
To: Jim Blandy <jimb@zwingli.cygnus.com>
Cc: Daniel Berlin <dan@cgsoftware.com>, gdb-patches@sources.redhat.com
Subject: Re: Rewriting the type system
Date: Mon, 11 Jun 2001 11:43:00 -0000	[thread overview]
Message-ID: <87d78aluw6.fsf@cgsoftware.com> (raw)
In-Reply-To: <npelsq28sh.fsf_-_@zwingli.cygnus.com>

Jim Blandy <jimb@zwingli.cygnus.com> writes:

> Daniel Berlin <dan@cgsoftware.com> writes:
>> While i'm redoing the type system, I was just about to ask a java
>> person the following:
>> in jv-lang.c, in java_array_type, it says "FIXME: This is bogus! Java
>> arrays are not gdb arrays!".
>> 
>> Could you please point me to where i can find out what java arrays
>> *are*, so i can make a type structure for them (the new typesystem is
>> a hierarchy of structs, rather than a single type struct.  This means
>> whatever java arrays *are*, can easily be represented and handled,
>> with no fuss or muss).
> 
> If you plan to submit a large, pervasive change for GDB, you will want
> to first explaing your change in detail on gdb@sources.redhat.com.
Errr, I did, a *long* time ago.

> The people who will approve or reject your patch read that list, and
> will almost certainly have some comments on the design.
They did.

>  By making
> sure the fundamental design of your change meets their requirements
> *before* you invest the time to turn your ideas into a patch, you may
> avoid having to rewrite the change from scratch.

Not a problem.  By the time the patch gets reviewed, it'll be rewritten anyway.
Even the very simple patch to add the misc obstack to the objfiles,
and stop putting things in the psymbol obstack that don't belong, from
May 29th, hasn't been reviewed yet.
Hell, the simple bcache change i submitted last year (updating the
starting constant, fix the indenting) still hasn't
been reviewed.

Jim, GDB development is moving a lot slower than it should.  If
someone told me, after just rewriting the typesystem, that i needed to
redo it from scratch, i'd probably just start making my own GDB
releases instead (in effect, forking GDB).  Not out of spite or
anything, just so i could get stuff done without having to keep track
of tons of patches that go months without review.

I'm now up to 15 people who ask me for my current tree weekly/monthly
(which contains  all my outstanding patches that haven't been
reviewed) instead of downloading cvs.

This, IMHO, is amazingly silly. The fact that the patches wait long
enough for others to notice, and get fed up enough with the current
state to ask me for the tree tells me something is very wrong here.

I usually wait a week before tarring up the tree, in hopes that maybe,
just maybe, someone will review whatever patches they are hoping to
get out of it.

Hasn't happened yet.

--Dan
-- 
"One time I went to a museum where all the work in the museum had
been done by children.  They had all the paintings up on
refrigerators.
"-Steven Wright


  parent reply	other threads:[~2001-06-11 11:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-07 23:22 obvious set_cu_language patch Per Bothner
2001-06-07 23:50 ` Daniel Berlin
2001-06-08 11:01   ` Per Bothner
2001-06-08 14:04     ` Stan Shebs
2001-06-08 14:34       ` Daniel Berlin
2001-06-08 13:04 ` Andrew Cagney
     [not found]   ` <m2pucevgf6.fsf@kelso.bothner.com>
2001-06-08 13:51     ` Daniel Berlin
     [not found]       ` <8766e6eke4.fsf@creche.redhat.com>
2001-06-08 14:23         ` Per Bothner
     [not found]       ` <npelsq28sh.fsf_-_@zwingli.cygnus.com>
2001-06-11 11:43         ` Daniel Berlin [this message]
2001-06-11 16:58           ` Rewriting the type system Stan Shebs
2001-06-12  1:44           ` Eli Zaretskii
2001-06-12  9:12             ` Daniel Berlin
2001-06-12 10:01               ` Eli Zaretskii
2001-06-12 10:16           ` Jim Blandy
2001-06-12 10:44             ` Daniel Berlin
2001-06-12 14:02               ` Stan Shebs
2001-06-13  1:45                 ` Eli Zaretskii
2001-06-12 11:08             ` Daniel Berlin
2001-06-12 14:03           ` Andrew Cagney
2001-06-12 21:37             ` Daniel Berlin
2001-06-25 14:13 ` obvious set_cu_language patch Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d78aluw6.fsf@cgsoftware.com \
    --to=dan@cgsoftware.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@zwingli.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox