Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks
Date: Mon, 21 Jan 2013 18:46:00 -0000	[thread overview]
Message-ID: <874nia2x3u.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130121170558.GA16410@host2.jankratochvil.net> (Jan	Kratochvil's message of "Mon, 21 Jan 2013 18:05:58 +0100")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> 	Code cleanup.
Jan> 	* breakpoint.c (clear_command): Remove variable is_abs, unify the
Jan> 	call of filename_cmp with compare_filenames_for_search.
[...]

Jan>      if (full_path != NULL)
Jan>        {
Jan> +	gdb_assert (IS_ABSOLUTE_PATH (full_path));
Jan> +	gdb_assert (IS_ABSOLUTE_PATH (name));

I wonder if these can really never trigger.

I think under some obscure conditions, xfullpath can return a relative
path, since gdb_realpath can.

Tom


  reply	other threads:[~2013-01-21 18:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 21:59 Jan Kratochvil
2013-01-18  7:32 ` Eli Zaretskii
2013-01-18 18:39   ` Jan Kratochvil
2013-01-18 19:20     ` Eli Zaretskii
2013-01-18 20:16       ` Jan Kratochvil
2013-01-18 20:40         ` Eli Zaretskii
2013-01-18 21:53           ` Jan Kratochvil
2013-01-19  6:50             ` Eli Zaretskii
2013-01-19 14:09               ` Jan Kratochvil
2013-01-19 15:18                 ` Eli Zaretskii
2013-01-19 15:27                   ` Jan Kratochvil
2013-01-19 16:02                     ` Eli Zaretskii
2013-01-21 17:06                     ` Jan Kratochvil
2013-01-21 18:46                       ` Tom Tromey [this message]
2013-01-21 19:43                         ` Jan Kratochvil
2013-01-21 20:48                           ` Tom Tromey
2013-01-18 21:11     ` [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks [resent] Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nia2x3u.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox