Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks
Date: Sat, 19 Jan 2013 16:02:00 -0000	[thread overview]
Message-ID: <8338xxqhy5.fsf@gnu.org> (raw)
In-Reply-To: <20130119152731.GA10298@host2.jankratochvil.net>

> Date: Sat, 19 Jan 2013 16:27:31 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org
> 
> "c:\filename.c" is absolute filename by definition so it must not match
> trailing part of a longer filename.

I agree, but the code never tests the other file name for being
absolute.  If it did, and then insisted that the other file name must
also be absolute, then I'd agree.


  reply	other threads:[~2013-01-19 16:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 21:59 Jan Kratochvil
2013-01-18  7:32 ` Eli Zaretskii
2013-01-18 18:39   ` Jan Kratochvil
2013-01-18 19:20     ` Eli Zaretskii
2013-01-18 20:16       ` Jan Kratochvil
2013-01-18 20:40         ` Eli Zaretskii
2013-01-18 21:53           ` Jan Kratochvil
2013-01-19  6:50             ` Eli Zaretskii
2013-01-19 14:09               ` Jan Kratochvil
2013-01-19 15:18                 ` Eli Zaretskii
2013-01-19 15:27                   ` Jan Kratochvil
2013-01-19 16:02                     ` Eli Zaretskii [this message]
2013-01-21 17:06                     ` Jan Kratochvil
2013-01-21 18:46                       ` Tom Tromey
2013-01-21 19:43                         ` Jan Kratochvil
2013-01-21 20:48                           ` Tom Tromey
2013-01-18 21:11     ` [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks [resent] Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8338xxqhy5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox