Re: [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Sat, 19 Jan 2013 16:18:57 +0100, Eli Zaretskii wrote:
> > For example when asking for a breakpoint at:
> > 	c:\filename.c:main
> > it must not match a debug info filename:
> > 	d:\foo\c:\filename.c
> 
> Why not?

Not sure how to reply that.

One uses absolute filenames (SEARCH_NAME in this case) to prevent any
ambiguities (resolved as multi-location breakpoints by GDB) due to the
dependence on "current directory" (which does not exist in GDB during linespec
resolution).

If an absolute filename can match trailing part of a longer filename then it
is not absolute filename by definition.

"c:\filename.c" is absolute filename by definition so it must not match
trailing part of a longer filename.


> Whatever.  I'm still unconvinced, I think the code is not sufficiently
> cleaned up.  But I'm tired of arguing.

Me too.  I will try to add some comment there in a next patch.


Thanks,
Jan