From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10850 invoked by alias); 19 Jan 2013 15:27:44 -0000 Received: (qmail 10841 invoked by uid 22791); 19 Jan 2013 15:27:43 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Jan 2013 15:27:37 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0JFRatO027288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 19 Jan 2013 10:27:36 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0JFRWPm019707 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 19 Jan 2013 10:27:35 -0500 Date: Sat, 19 Jan 2013 15:27:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks Message-ID: <20130119152731.GA10298@host2.jankratochvil.net> References: <20130117215846.GC16249@host2.jankratochvil.net> <83fw1z6j5i.fsf@gnu.org> <20130118183938.GA1255@host2.jankratochvil.net> <83r4li5mdj.fsf@gnu.org> <20130118193457.GA4369@host2.jankratochvil.net> <83mww65iok.fsf@gnu.org> <20130118211002.GA9261@host2.jankratochvil.net> <83d2x1r7iy.fsf@gnu.org> <20130119140914.GA7303@host2.jankratochvil.net> <834nidqjz2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <834nidqjz2.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00465.txt.bz2 On Sat, 19 Jan 2013 16:18:57 +0100, Eli Zaretskii wrote: > > For example when asking for a breakpoint at: > > c:\filename.c:main > > it must not match a debug info filename: > > d:\foo\c:\filename.c > > Why not? Not sure how to reply that. One uses absolute filenames (SEARCH_NAME in this case) to prevent any ambiguities (resolved as multi-location breakpoints by GDB) due to the dependence on "current directory" (which does not exist in GDB during linespec resolution). If an absolute filename can match trailing part of a longer filename then it is not absolute filename by definition. "c:\filename.c" is absolute filename by definition so it must not match trailing part of a longer filename. > Whatever. I'm still unconvinced, I think the code is not sufficiently > cleaned up. But I'm tired of arguing. Me too. I will try to add some comment there in a next patch. Thanks, Jan