From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31790 invoked by alias); 21 Jan 2013 18:46:08 -0000 Received: (qmail 31775 invoked by uid 22791); 21 Jan 2013 18:46:07 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jan 2013 18:46:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0LIjw21029493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 21 Jan 2013 13:45:59 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0LIjvE2025804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 21 Jan 2013 13:45:57 -0500 From: Tom Tromey To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks References: <83fw1z6j5i.fsf@gnu.org> <20130118183938.GA1255@host2.jankratochvil.net> <83r4li5mdj.fsf@gnu.org> <20130118193457.GA4369@host2.jankratochvil.net> <83mww65iok.fsf@gnu.org> <20130118211002.GA9261@host2.jankratochvil.net> <83d2x1r7iy.fsf@gnu.org> <20130119140914.GA7303@host2.jankratochvil.net> <834nidqjz2.fsf@gnu.org> <20130119152731.GA10298@host2.jankratochvil.net> <20130121170558.GA16410@host2.jankratochvil.net> Date: Mon, 21 Jan 2013 18:46:00 -0000 In-Reply-To: <20130121170558.GA16410@host2.jankratochvil.net> (Jan Kratochvil's message of "Mon, 21 Jan 2013 18:05:58 +0100") Message-ID: <874nia2x3u.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00487.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Code cleanup. Jan> * breakpoint.c (clear_command): Remove variable is_abs, unify the Jan> call of filename_cmp with compare_filenames_for_search. [...] Jan> if (full_path != NULL) Jan> { Jan> + gdb_assert (IS_ABSOLUTE_PATH (full_path)); Jan> + gdb_assert (IS_ABSOLUTE_PATH (name)); I wonder if these can really never trigger. I think under some obscure conditions, xfullpath can return a relative path, since gdb_realpath can. Tom