From: Sam James <sam@gentoo.org>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3 0/8] Correctly handle inline functions with dwz
Date: Mon, 23 Feb 2026 13:48:04 +0000 [thread overview]
Message-ID: <874in7muzv.fsf@gentoo.org> (raw)
In-Reply-To: <79a477ec-dace-4893-9145-be2a0ccd6cd1@simark.ca>
[-- Attachment #1: Type: text/plain, Size: 2506 bytes --]
Simon Marchi <simark@simark.ca> writes:
> On 2026-02-23 08:30, Sam James wrote:
>> Tom Tromey <tom@tromey.com> writes:
>>
>>> The new indexer does not correctly handle inline functions when 'dwz'
>>> is used to compress the DWARF. This series fixes the bug, cleaning up
>>> a number of other things on the way.
>>>
>>> I've separately regression tested each patch in this series on x86-64
>>> Fedora 41. I've also regression tested the series as a whole with the
>>> dwz, gdb-index, and debug-names boards.
>>>
>>> Even with that I messed up somehow, so v1 didn't actually fix the bug
>>> in question. I must have modified the patches after testing..?
>>>
>>> Anyway in v2 I've moved the line recording the CU inclusion and added
>>> a comment explaining the placement. I re-ran the aformentioned tests
>>> and didn't touch anything.
>>
>> With this, I get a crash when creating an index:
>> ```
>> $ /usr/bin/gdb --batch -nx -iex set\ auto-load\ no -iex set\ debuginfod\
>> enabled\ off -ex file\
>> \'/var/tmp/portage/dev-debug/gdb-9999/image/usr/bin/gdb\' -ex save\
>> gdb-index\ -dwarf-5\
>> \'/var/tmp/portage/dev-debug/gdb-9999/image/usr/bin\'
>> dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed.
>> A problem internal to GDB has been detected,
>> further debugging may prove unreliable.
>> ----- Backtrace -----
>> 0x561db97db67e ???
>> 0x561db9fd8a04 ???
>> 0x561dba59b487 ???
>> 0x561db9918fe0 ???
>> 0x561db991fb47 ???
>> 0x561db9927e99 ???
>> 0x561db99282e0 ???
>> 0x561db9f12f56 ???
>> 0x561db9b6612c ???
>> 0x561db9b6cbfb ???
>> 0x561db9644baf ???
>> 0x7f8b51c03649 ???
>> 0x7f8b51c03765 ???
>> 0x561db96648d0 ???
>> 0xffffffffffffffff ???
>> ---------------------
>> dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed.
>> A problem internal to GDB has been detected,
>> further debugging may prove unreliable.
>> Quit this debugging session? (y or n) [answered Y; input not from terminal]
>>
>> This is a bug, please report it. For instructions, see:
>> <https://bugs.gentoo.org/>.
>>
>> dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed.
>> A problem internal to GDB has been detected,
>> further debugging may prove unreliable.
>> Create a core file of GDB? (y or n) [answered Y; input not from
>> terminal]
>> ```
>
> Are you able to share the binary?
Sure: https://dev.gentoo.org/~sam/tmp/gdb.xz
>
> Simon
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 418 bytes --]
next prev parent reply other threads:[~2026-02-23 13:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 20:42 Tom Tromey
2026-02-20 20:42 ` [PATCH v3 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-02-20 20:42 ` [PATCH v3 4/8] Combine two cases in cooked_index_functions::search Tom Tromey
2026-02-20 20:42 ` [PATCH v3 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-02-20 20:42 ` [PATCH v3 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-02-20 20:42 ` [PATCH v3 7/8] Handle inline functions with dwz Tom Tromey
2026-02-20 20:42 ` [PATCH v3 8/8] Update .debug_names documentation Tom Tromey
2026-02-23 13:30 ` [PATCH v3 0/8] Correctly handle inline functions with dwz Sam James
2026-02-23 13:32 ` Sam James
2026-02-23 13:34 ` Simon Marchi
2026-02-23 13:48 ` Sam James [this message]
2026-02-23 22:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874in7muzv.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox