From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH v3 4/8] Combine two cases in cooked_index_functions::search
Date: Fri, 20 Feb 2026 13:42:24 -0700 [thread overview]
Message-ID: <20260220-dw-inline-fixup-pr-symtab-30728-2-v3-4-98ae8ab28fab@tromey.com> (raw)
In-Reply-To: <20260220-dw-inline-fixup-pr-symtab-30728-2-v3-0-98ae8ab28fab@tromey.com>
This combines a couple of 'if' statements in
cooked_index_functions::search. This simplifies the code a little and
also makes a subsequent patch a bit simpler as well.
---
gdb/dwarf2/read.c | 27 ++++++++++++---------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index f545a3158e9..184ffe1c213 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -14188,25 +14188,22 @@ cooked_index_functions::search
|| !entry->matches (domain))
continue;
- if (lang_matcher != nullptr)
+ /* If LANG_MATCHER is non-NULL, try to skip CUs with a
+ non-matching language. The other case here is a bit of a
+ hack to support .gdb_index. Since .gdb_index does not
+ record languages, and since we want to know the language
+ to avoid excessive CU expansion due to false matches, if
+ we see a symbol with an unknown language we find the CU's
+ language. Only the .gdb_index reader creates such
+ symbols. */
+ enum language entry_lang = entry->lang;
+ if (lang_matcher != nullptr || entry_lang == language_unknown)
{
- /* Try to skip CUs with non-matching language. */
entry->per_cu->ensure_lang (per_objfile);
- if (!entry->per_cu->maybe_multi_language ()
+ if (lang_matcher != nullptr
+ && !entry->per_cu->maybe_multi_language ()
&& !lang_matcher (entry->per_cu->lang ()))
continue;
- }
-
- /* This is a bit of a hack to support .gdb_index. Since
- .gdb_index does not record languages, and since we want
- to know the language to avoid excessive CU expansion due
- to false matches, if we see a symbol with an unknown
- language we find the CU's language. Only the .gdb_index
- reader creates such symbols. */
- enum language entry_lang = entry->lang;
- if (entry_lang == language_unknown)
- {
- entry->per_cu->ensure_lang (per_objfile);
entry_lang = entry->per_cu->lang ();
}
--
2.49.0
next prev parent reply other threads:[~2026-02-20 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 20:42 [PATCH v3 0/8] Correctly handle inline functions with dwz Tom Tromey
2026-02-20 20:42 ` [PATCH v3 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-02-20 20:42 ` Tom Tromey [this message]
2026-02-20 20:42 ` [PATCH v3 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-02-20 20:42 ` [PATCH v3 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-02-20 20:42 ` [PATCH v3 7/8] Handle inline functions with dwz Tom Tromey
2026-02-20 20:42 ` [PATCH v3 8/8] Update .debug_names documentation Tom Tromey
2026-02-23 13:30 ` [PATCH v3 0/8] Correctly handle inline functions with dwz Sam James
2026-02-23 13:32 ` Sam James
2026-02-23 13:34 ` Simon Marchi
2026-02-23 13:48 ` Sam James
2026-02-23 22:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220-dw-inline-fixup-pr-symtab-30728-2-v3-4-98ae8ab28fab@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox