From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>
Subject: [PATCH v3 0/8] Correctly handle inline functions with dwz
Date: Fri, 20 Feb 2026 13:42:20 -0700 [thread overview]
Message-ID: <20260220-dw-inline-fixup-pr-symtab-30728-2-v3-0-98ae8ab28fab@tromey.com> (raw)
The new indexer does not correctly handle inline functions when 'dwz'
is used to compress the DWARF. This series fixes the bug, cleaning up
a number of other things on the way.
I've separately regression tested each patch in this series on x86-64
Fedora 41. I've also regression tested the series as a whole with the
dwz, gdb-index, and debug-names boards.
Even with that I messed up somehow, so v1 didn't actually fix the bug
in question. I must have modified the patches after testing..?
Anyway in v2 I've moved the line recording the CU inclusion and added
a comment explaining the placement. I re-ran the aformentioned tests
and didn't touch anything.
Signed-off-by: Tom Tromey <tom@tromey.com>
---
Changes in v3:
- Minor updates per review
- Rebased; which required some changes to the
iterate_over_one_compunit_symtab patch
- Link to v2: https://inbox.sourceware.org/gdb-patches/20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com
Changes in v2:
- Fixed fix from Tom de Vries for IS_INLINED debug display
- Moved line to record inclusion
- Link to v1: https://inbox.sourceware.org/gdb-patches/20260125-dw-inline-fixup-pr-symtab-30728-2-v1-0-e9973a4a401a@tromey.com
---
Tom Tromey (8):
Don't call add_dependence from index_imported_unit
Skip partial units in process_psymtab_comp_unit
Don't consider DW_TAG_inlined_subroutine as interesting
Combine two cases in cooked_index_functions::search
Remove C++ special case from process_imported_unit_die
Have iterate_over_one_compunit_symtab search included symtabs
Handle inline functions with dwz
Update .debug_names documentation
gdb/doc/gdb.texinfo | 37 +++++++
gdb/dwarf2/abbrev.c | 1 -
gdb/dwarf2/cooked-index-entry.c | 24 +++++
gdb/dwarf2/cooked-index-entry.h | 39 ++++++-
gdb/dwarf2/cooked-index-worker.c | 14 +++
gdb/dwarf2/cooked-index-worker.h | 26 +++--
gdb/dwarf2/cooked-indexer.c | 60 +++++++----
gdb/dwarf2/cooked-indexer.h | 8 +-
gdb/dwarf2/cu.h | 6 +-
gdb/dwarf2/index-write.c | 223 ++++++++++++++++++++++-----------------
gdb/dwarf2/read.c | 85 +++++++++------
gdb/dwarf2/read.h | 37 +++++++
gdb/symfile-debug.c | 23 ++--
13 files changed, 406 insertions(+), 177 deletions(-)
---
base-commit: e16c7848007e4faa071a6483556e69f365e9eb69
change-id: 20260125-dw-inline-fixup-pr-symtab-30728-2-7c31bf38fbe3
Best regards,
--
Tom Tromey <tom@tromey.com>
next reply other threads:[~2026-02-20 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 20:42 Tom Tromey [this message]
2026-02-20 20:42 ` [PATCH v3 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-02-20 20:42 ` [PATCH v3 4/8] Combine two cases in cooked_index_functions::search Tom Tromey
2026-02-20 20:42 ` [PATCH v3 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-02-20 20:42 ` [PATCH v3 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-02-20 20:42 ` [PATCH v3 7/8] Handle inline functions with dwz Tom Tromey
2026-02-20 20:42 ` [PATCH v3 8/8] Update .debug_names documentation Tom Tromey
2026-02-23 13:30 ` [PATCH v3 0/8] Correctly handle inline functions with dwz Sam James
2026-02-23 13:32 ` Sam James
2026-02-23 13:34 ` Simon Marchi
2026-02-23 13:48 ` Sam James
2026-02-23 22:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220-dw-inline-fixup-pr-symtab-30728-2-v3-0-98ae8ab28fab@tromey.com \
--to=tom@tromey.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox