From: Tom Tromey <tom@tromey.com>
To: Sam James <sam@gentoo.org>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3 0/8] Correctly handle inline functions with dwz
Date: Mon, 23 Feb 2026 15:31:05 -0700 [thread overview]
Message-ID: <87342rrt1y.fsf@tromey.com> (raw)
In-Reply-To: <87ldgjmvtv.fsf@gentoo.org> (Sam James's message of "Mon, 23 Feb 2026 13:30:04 +0000")
>>>>> "Sam" == Sam James <sam@gentoo.org> writes:
Sam> dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed.
Thanks for sending the executable.
The assert here is wrong now, because a given cooked_index_entry can be
seen twice in this loop -- but only when the entry represents an inline
function.
The fix is to rewrite the assert:
gdb_assert (offset_inserted
|| (entry->flags & IS_INLINED) != 0);
I'm looking to see how I can turn this into a test case.
Tom
prev parent reply other threads:[~2026-02-23 22:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 20:42 Tom Tromey
2026-02-20 20:42 ` [PATCH v3 1/8] Don't call add_dependence from index_imported_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 2/8] Skip partial units in process_psymtab_comp_unit Tom Tromey
2026-02-20 20:42 ` [PATCH v3 3/8] Don't consider DW_TAG_inlined_subroutine as interesting Tom Tromey
2026-02-20 20:42 ` [PATCH v3 4/8] Combine two cases in cooked_index_functions::search Tom Tromey
2026-02-20 20:42 ` [PATCH v3 5/8] Remove C++ special case from process_imported_unit_die Tom Tromey
2026-02-20 20:42 ` [PATCH v3 6/8] Have iterate_over_one_compunit_symtab search included symtabs Tom Tromey
2026-02-20 20:42 ` [PATCH v3 7/8] Handle inline functions with dwz Tom Tromey
2026-02-20 20:42 ` [PATCH v3 8/8] Update .debug_names documentation Tom Tromey
2026-02-23 13:30 ` [PATCH v3 0/8] Correctly handle inline functions with dwz Sam James
2026-02-23 13:32 ` Sam James
2026-02-23 13:34 ` Simon Marchi
2026-02-23 13:48 ` Sam James
2026-02-23 22:31 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87342rrt1y.fsf@tromey.com \
--to=tom@tromey.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox