From: Tom Tromey <tom@tromey.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Fix BFD leak in solib-darwin.c
Date: Tue, 26 Feb 2019 20:19:00 -0000 [thread overview]
Message-ID: <8736oae21e.fsf@tromey.com> (raw)
In-Reply-To: <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org> (John Baldwin's message of "Fri, 22 Feb 2019 09:16:13 -0800")
>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
Re-replying...
John> Simon has noticed several instances of this bug where release()
John> was used instead of reset().
I wonder whether we ought to mark the release method as
"warn_unused_result" to try to avoid future bugs like this. Another
idea is to try to reduce the number of calls to release generally, by
changing more things to take rvalue references or the like.
Tom
next prev parent reply other threads:[~2019-02-26 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 16:36 Tom Tromey
[not found] ` <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org>
2019-02-22 21:43 ` John Baldwin
2019-02-25 13:50 ` Tom Tromey
2019-02-26 20:19 ` Tom Tromey [this message]
2019-02-26 20:36 ` John Baldwin
2019-02-26 22:02 ` Tom Tromey
2019-02-23 0:32 ` Pedro Alves
2019-02-25 13:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736oae21e.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox