From: John Baldwin <jhb@FreeBSD.org>
To: Tom Tromey <tom@tromey.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Fix BFD leak in solib-darwin.c
Date: Tue, 26 Feb 2019 20:36:00 -0000 [thread overview]
Message-ID: <d0e8806d-92ad-f7f0-4514-f77f6c95798b@FreeBSD.org> (raw)
In-Reply-To: <8736oae21e.fsf@tromey.com>
On 2/26/19 12:18 PM, Tom Tromey wrote:
>>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
>
> Re-replying...
>
> John> Simon has noticed several instances of this bug where release()
> John> was used instead of reset().
>
> I wonder whether we ought to mark the release method as
> "warn_unused_result" to try to avoid future bugs like this. Another
> idea is to try to reduce the number of calls to release generally, by
> changing more things to take rvalue references or the like.
I think the warning would be useful if it doesn't trigger a lot of false
positives. I feel like it wouldn't today. When I was grep'ing for
'release ()' I only focused on the calls that weren't assigning a value
to a result and I feel like there weren't many of those (and some were
assigning, just not obvious in the one line of grep context).
--
John Baldwin
                                                                           Â
next prev parent reply other threads:[~2019-02-26 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 16:36 Tom Tromey
[not found] ` <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org>
2019-02-22 21:43 ` John Baldwin
2019-02-25 13:50 ` Tom Tromey
2019-02-26 20:19 ` Tom Tromey
2019-02-26 20:36 ` John Baldwin [this message]
2019-02-26 22:02 ` Tom Tromey
2019-02-23 0:32 ` Pedro Alves
2019-02-25 13:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0e8806d-92ad-f7f0-4514-f77f6c95798b@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox