From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Fix BFD leak in solib-darwin.c
Date: Mon, 25 Feb 2019 13:51:00 -0000 [thread overview]
Message-ID: <87tvgsx9h0.fsf@tromey.com> (raw)
In-Reply-To: <49527b82-328e-e129-21d1-cbc333c70ca7@redhat.com> (Pedro Alves's message of "Sat, 23 Feb 2019 00:32:01 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 02/22/2019 04:36 PM, Tom Tromey wrote:
>> if (sub != NULL)
>> dyld_bfd = sub;
>> else
>> - dyld_bfd.release ();
>> + dyld_bfd.reset (nullptr);
Pedro> These 4 lines are now equivalent to just doing:
Pedro> dyld_bfd = sub;
I made this change and I'm going to commit it shortly.
Tom
next prev parent reply other threads:[~2019-02-25 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 16:36 Tom Tromey
2019-02-23 0:32 ` Pedro Alves
2019-02-25 13:51 ` Tom Tromey [this message]
[not found] ` <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org>
2019-02-22 21:43 ` John Baldwin
2019-02-25 13:50 ` Tom Tromey
2019-02-26 20:19 ` Tom Tromey
2019-02-26 20:36 ` John Baldwin
2019-02-26 22:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvgsx9h0.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox