From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57820 invoked by alias); 26 Feb 2019 20:19:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57775 invoked by uid 89); 26 Feb 2019 20:19:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=solibdarwinc, UD:solib-darwin.c, solib-darwin.c X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.126.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Feb 2019 20:18:58 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 00E72400C84E3 for ; Tue, 26 Feb 2019 13:33:53 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id yjBmgEfFL4FKpyjBmgWfRF; Tue, 26 Feb 2019 14:18:55 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=heGiA+0nJVBwSnW4BO1sERxnZJqCd7x9ctK0Jr5V+Ks=; b=Wgy3bAeVB7aOWdDiup+Ibxg36H zCaqxLSA+uvl045q18qQE4ZvQ5Rp/4zrphNkaBcd8cQFLQLd7N9yh2oTvkl6luK9gkzraGeo4vBm+ B3YQekpuxvQ8ScHdl+aSHpxvu; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:35160 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gyjBm-003Fjm-NZ; Tue, 26 Feb 2019 14:18:54 -0600 From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC] Fix BFD leak in solib-darwin.c References: <20190222163645.9349-1-tromey@adacore.com> <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org> Date: Tue, 26 Feb 2019 20:19:00 -0000 In-Reply-To: <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org> (John Baldwin's message of "Fri, 22 Feb 2019 09:16:13 -0800") Message-ID: <8736oae21e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00454.txt.bz2 >>>>> "John" == John Baldwin writes: Re-replying... John> Simon has noticed several instances of this bug where release() John> was used instead of reset(). I wonder whether we ought to mark the release method as "warn_unused_result" to try to avoid future bugs like this. Another idea is to try to reduce the number of calls to release generally, by changing more things to take rvalue references or the like. Tom