From: Tom Tromey <tromey@redhat.com>
To: ali_anwar <ali_anwar@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: Updated patch for Bug 13217 - thread apply all detach throws a SEGFAULT
Date: Thu, 27 Sep 2012 15:32:00 -0000 [thread overview]
Message-ID: <871uhnwkf3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5062EA9B.1060505@codesourcery.com> (ali anwar's message of "Wed, 26 Sep 2012 16:44:27 +0500")
>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:
Ali> +static int
Ali> +thread_valid (struct thread_info *tp)
Ali> +{
Ali> + struct thread_info *utp;
Ali> + for (utp = thread_list; utp; utp = utp->next)
Ali> + if (tp == utp)
Ali> + return 1;
Ali> + return 0;
Ali> +}
Ali> + for (tp = thread_list; thread_valid(tp); tp = tp->next)
It seems like this introduces quadratic behavior here.
I think it would be better to avoid this.
Ali> + if (thread_count() == 0)
Ali> + break;
Here too.
Tom
next prev parent reply other threads:[~2012-09-27 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 11:46 ali_anwar
2012-09-26 11:50 ` ali_anwar
2012-09-27 15:27 ` Jan Kratochvil
2012-09-27 15:32 ` Tom Tromey [this message]
2012-12-10 18:37 ` ali_anwar
2012-12-10 20:20 ` Tom Tromey
2012-12-11 15:37 ` ali_anwar
2012-12-11 16:43 ` Pedro Alves
2013-07-10 10:31 ` ali_anwar
2013-07-10 12:57 ` Joel Brobecker
2013-07-10 17:55 ` Tom Tromey
2013-07-11 12:30 ` ali_anwar
2013-07-13 21:13 ` Tom Tromey
2013-07-15 11:20 ` ali_anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uhnwkf3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ali_anwar@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox