From: ali_anwar <ali_anwar@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: Updated patch for Bug 13217 - thread apply all detach throws a SEGFAULT
Date: Mon, 15 Jul 2013 11:20:00 -0000 [thread overview]
Message-ID: <51E3DAD7.3050100@codesourcery.com> (raw)
In-Reply-To: <878v1anoz2.fsf@fleche.redhat.com>
On 07/14/2013 02:12 AM, Tom Tromey wrote:
>>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:
>
> Ali> Please find attached updated patch.
>
> Thanks.
>
> Ali> + struct thread_info **tp_array;
> Ali> + struct thread_info *tp;
> Ali> + int i, k;
> Ali> + i = 0;
>
> Either there should be a blank line between the declarations and the
> assignment here, or the declaration should read "int i = 0, k;".
>
> This patch is ok with this fixed.
>
Thanks, committed the patch with the suggested change.
-Ali
prev parent reply other threads:[~2013-07-15 11:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 11:46 ali_anwar
2012-09-26 11:50 ` ali_anwar
2012-09-27 15:27 ` Jan Kratochvil
2012-09-27 15:32 ` Tom Tromey
2012-12-10 18:37 ` ali_anwar
2012-12-10 20:20 ` Tom Tromey
2012-12-11 15:37 ` ali_anwar
2012-12-11 16:43 ` Pedro Alves
2013-07-10 10:31 ` ali_anwar
2013-07-10 12:57 ` Joel Brobecker
2013-07-10 17:55 ` Tom Tromey
2013-07-11 12:30 ` ali_anwar
2013-07-13 21:13 ` Tom Tromey
2013-07-15 11:20 ` ali_anwar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E3DAD7.3050100@codesourcery.com \
--to=ali_anwar@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox